<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Fri, 26 Jan 2018 at 13:04 Ethan Furman <<a href="mailto:ethan@stoneleaf.us">ethan@stoneleaf.us</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 01/26/2018 09:28 AM, Mariatta Wijaya wrote:<br>
<br>
>     So when the original PR didn't have a news entry, what should I have seen to alert me to that?<br>
><br>
> If a news entry is missing from the PR, the CI check at the bottom of the PR will fail.<br>
> You should see the following:<br>
><br>
> bedevere/news -- No news entry in Misc/NEWS.d/next/ or "skip news" label found<br>
><br>
> An example can be seen here (at least at the time I write this email)<br>
> <a href="https://github.com/python/cpython/pull/5347" rel="noreferrer" target="_blank">https://github.com/python/cpython/pull/5347</a><br>
<br>
Okay, I see it in your example.  Here's the PR I'm talking about:<br>
<br>
   <a href="https://github.com/python/cpython/pull/5103" rel="noreferrer" target="_blank">https://github.com/python/cpython/pull/5103</a><br>
<br>
I see no NEWS commit, and no "missing news" alert.  Did I misstep somewhere?<br></blockquote><div><br></div><div>No, you just missed the news entry: <a href="https://github.com/python/cpython/pull/5103/files#diff-b1662ec7a5e858b21ea9fe160546636f">https://github.com/python/cpython/pull/5103/files#diff-b1662ec7a5e858b21ea9fe160546636f</a> .<br></div></div></div>