<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Sun, 22 Apr 2018 at 11:27 Terry Reedy <<a href="mailto:tjreedy@udel.edu">tjreedy@udel.edu</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 4/22/2018 12:16 PM, Serhiy Storchaka wrote:<br>
> miss-islington is an awesome bot! It makes fixing bugs in multiple <br>
> versions much simpler. You need just accept automatically created <br>
> backporting PRs.<br>
> <br>
> But there is a downside. miss-islington makes the life so easier, that <br>
> sometimes you forgot about not finished backports. miss-islington can <br>
> fail to backport some changes for different reasons. Currently on GitHub <br>
> there are tens merged PRs labeled for backporting, but backports were <br>
> not finished. Please take attention if your PRs in one of the following <br>
> lists:<br>
<br>
Does github allow repository owners to send email directly to people who <br>
have submitted PRs or at least, people with commit privileges (in this <br>
case, those whose have done particular merges)?<br></blockquote><div><br></div><div>No. People have to provide explicit permission to expose their email address. Otherwise the best we have are @ mentions in a comment.<br><br></div><div>-Brett<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
> <a href="https://github.com/python/cpython/pulls?q=label%3A%22needs+backport+to+3.7%22+is%3Aclosed" rel="noreferrer" target="_blank">https://github.com/python/cpython/pulls?q=label%3A%22needs+backport+to+3.7%22+is%3Aclosed</a> <br>
<br>
> <a href="https://github.com/python/cpython/pulls?q=label%3A%22needs+backport+to+3.6%22+is%3Aclosed" rel="noreferrer" target="_blank">https://github.com/python/cpython/pulls?q=label%3A%22needs+backport+to+3.6%22+is%3Aclosed</a> <br>
<br>
Several of these were closed without merging and should not and cannot <br>
be backported.  For instance, you closed<br>
<a href="https://github.com/python/cpython/pull/4225" rel="noreferrer" target="_blank">https://github.com/python/cpython/pull/4225</a><br>
after you submitted and merged a replacement.<br>
<a href="https://github.com/python/cpython/pull/6259" rel="noreferrer" target="_blank">https://github.com/python/cpython/pull/6259</a><br>
<br>
Stripping backport labels off of rejected PRs could be considered.  But <br>
this would toss information needed for a new PR if the bpo issue is <br>
open.  Expecting either the submitter or merged of a replacement to go <br>
back and clean up the original seems a bit much.  The submitter might <br>
not be able to, and the merger might not know or forget that the PR is a <br>
replacement.  Perhaps rejected PRs should just be ignored.<br>
<br>
Replacing 'closed' with 'merged' excludes rejected PRs.<br>
<br>
<a href="https://github.com/python/cpython/pulls?q=label%3A%22needs+backport+to+3.6%22+is%3Amerged" rel="noreferrer" target="_blank">https://github.com/python/cpython/pulls?q=label%3A%22needs+backport+to+3.6%22+is%3Amerged</a><br>
<br>
> <a href="https://github.com/python/cpython/pulls?q=label%3A%22needs+backport+to+2.7%22+is%3Aclosed" rel="noreferrer" target="_blank">https://github.com/python/cpython/pulls?q=label%3A%22needs+backport+to+2.7%22+is%3Aclosed</a> <br>
<br>
<a href="https://github.com/python/cpython/pulls?q=label%3A%22needs+backport+to+2.7%22+is%3Amerged" rel="noreferrer" target="_blank">https://github.com/python/cpython/pulls?q=label%3A%22needs+backport+to+2.7%22+is%3Amerged</a><br>
<br>
The 2.7 backport of <a href="https://github.com/python/cpython/pull/3639" rel="noreferrer" target="_blank">https://github.com/python/cpython/pull/3639</a><br>
is yours.<br>
<br>
tjr<br>
<br>
_______________________________________________<br>
python-committers mailing list<br>
<a href="mailto:python-committers@python.org" target="_blank">python-committers@python.org</a><br>
<a href="https://mail.python.org/mailman/listinfo/python-committers" rel="noreferrer" target="_blank">https://mail.python.org/mailman/listinfo/python-committers</a><br>
Code of Conduct: <a href="https://www.python.org/psf/codeofconduct/" rel="noreferrer" target="_blank">https://www.python.org/psf/codeofconduct/</a><br>
</blockquote></div></div>