[Python-Dev] Re: [Python-checkins]
python/dist/src/Objectstupleobject.c, 2.86, 2.87
tim.one at comcast.net
Tue Mar 23 11:06:24 EST 2004
arigo> memset() hunt continuing. This is a net win.
> Maybe we should cast this as a _Py_MEMSET macro to make it more
> obvious what's been done?
An inline memset loop is quite clear on its own, so it's fine by me if
inlined-for-speed memset loops are simply commented as to why they're being
done inline. A comment at the site is evidence that someone actually
thought about it, and maybe even tried it both ways; using a macro without
comment might well be due to monkey-see monkey-do, or inappropriate
copy-&-paste. IOW, I think defining a macro would make it less obvious.
Comments require more effort, and in these cases that's good.
More information about the Python-Dev