[Python-Dev] Five patch reviews & patch request

Thomas Heller theller at python.net
Fri Jun 10 19:46:00 CEST 2005


"Michiel De Hoon" <mdehoon at c2b2.columbia.edu> writes:

> I'd like to ask your attention to this patch:
>
> [ 1049855 ] PyOS_InputHook inconsistency on Windows
>
> Kurt Kaiser has already looked at this patch, but was hesitant to check it in
> because he wasn't able to test it on Windows. I'd be happy to send a compiled
> Python for Windows to anybody willing to have a look at this patch.

Comment about the patch (only from reading it):

The PyOS_StdioReadline function calls my_fgets with a file pointer
argument.  The my_fgets function in the patch assumes that
STD_INPUT_HANDLE is the handle to use - is this assumption always
correct?

Thomas



More information about the Python-Dev mailing list