<br>My only objection (which is a minor one) is with the 'NOARGS_NULL' name. Caps don't fit the normal style rules, and 'noargs_null' doesn't make much sense to me. 'unused' strikes me as a clearer name (or 'noargs_unused' or 'args_unused' or such.) It should be fine to fix this in
2.5 as well (as long as arguments previously ignored don't suddenly raise exceptions, but it doesn't sound like that's happening at all.)<br><br><div><span class="gmail_quote">On 2/18/07, <b class="gmail_sendername">
"Martin v. Löwis"</b> <<a href="mailto:martin@v.loewis.de">martin@v.loewis.de</a>> wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Patch #1648268 corrects a huge load of errors in Python wrt.<br>incorrect function pointers (i.e. functions called with a<br>different signature then declared, through pointers).<br>The rationale for this patch is that the submitter apparently
<br>has a platform where Python crashes in the face of these errors.<br><br>I believe the patch is correct, and would like to apply it.<br><br>The patch also renames many function arguments: parameters<br>in a METH_NOARGS function get consistently named NOARGS_NULL
<br>(currently often called 'unused' or 'noargs'); the second parameter<br>to getters gets consistently named 'closure' (it's called<br>closure in many places already, and 'unused' in others).
<br><br>I would also apply this part of the change, and both to<br>the trunk and Python 2.5. Objections?<br><br>Regards,<br>Martin<br>_______________________________________________<br>Python-Dev mailing list<br><a href="mailto:Python-Dev@python.org">
Python-Dev@python.org</a><br><a href="http://mail.python.org/mailman/listinfo/python-dev">http://mail.python.org/mailman/listinfo/python-dev</a><br>Unsubscribe: <a href="http://mail.python.org/mailman/options/python-dev/thomas%40python.org">
http://mail.python.org/mailman/options/python-dev/thomas%40python.org</a><br></blockquote></div><br><br clear="all"><br>-- <br>Thomas Wouters <<a href="mailto:thomas@python.org">thomas@python.org</a>><br><br>Hi! I'm a .signature virus! copy me into your .signature file to help me spread!