Fred,<br><br>My only motivation was style.<br><br>As per your comment:<br><br>"In general, we try to avoid making style changes to the code since that can<br>increase the maintenance burden (patches can be harder to produce that can be
<br>cleanly applied to multiple versions)."<br><br>I will keep this in mind when supplying future patches.<br><br><br>Joseph Armbruster<br><br><br><div><span class="gmail_quote">On 5/31/07, <b class="gmail_sendername">
Fred L. Drake, Jr.</b> <<a href="mailto:fdrake@acm.org">fdrake@acm.org</a>> wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
On Saturday 26 May 2007, Joseph Armbruster wrote:<br> > I noticed that one of the parts of ConfigParser was not using "for line<br> > in fp" style of readline-ing :-) So, this will reduce the SLOC by 3<br>
> lines and improve readability. However, I did a quick grep and this<br> > type of practice appears in several other places.<br><br>Before the current iteration support was part of Python, there was no way to<br>
iterate over a the way there is now; the code you've dug up is simply from<br>before the current iteration support. (As I'm sure you know.)<br><br>Is there motivation for these changes other than a stylistic preference for
<br>the newer idioms? Keeping the SLOC count down seems pretty minimal, and<br>unimportant. Making the code more understandable is valuable, but it's not<br>clear how much this really achieves that.<br><br>In general, we try to avoid making style changes to the code since that can
<br>increase the maintenance burden (patches can be harder to produce that can be<br>cleanly applied to multiple versions).</blockquote><div><br>No other motivat <br></div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Are there motivations we're missing?<br><br><br> -Fred<br><br>--<br>Fred L. Drake, Jr. <fdrake at <a href="http://acm.org">acm.org</a>><br></blockquote></div><br>