<br><br><div class="gmail_quote">On Tue, Apr 15, 2008 at 7:21 AM, "Martin v. Löwis" <<a href="mailto:martin@v.loewis.de">martin@v.loewis.de</a>> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="Ih2E3d">> I think it would be useful for the tracker to grow a "NeedsReview"<br>
> keyword. I realize the "patch" keyword does some of this, but it may<br>
> just represent some initial or trivial work. "NeedsReview" should<br>
> represent a mature patch that some senior dev needs to look hard at<br>
> and make the choice.<br>
<br>
</div>Not sure what problem that would solve. Over time, I would expect that<br>
any open patch also grows the "NeedsReview" keyword, making the keyword<br>
pointless. If somebody specifically should review a certain proposed<br>
change, the change should be assigned to that person. If someone in<br>
a group should review, they should be contacted by email.<br>
</blockquote><div><br>I think it would be nice if that patch keyword could be set by non-admins.<br>This would mean I didn't have to write to the mailing list asking for people to look at <br>some specific bug. Like "did someone look at <a href="http://bugs.python.org/issue2122">http://bugs.python.org/issue2122</a>. This isssue is about mmap.flush not raising an exception on errors. which I think is a rather severe". (btw. can someone please look at it? :) )<br>
<br>Regards,<br>- Ralf<br><br><br></div></div><br>