<br><br><div class="gmail_quote">On Sun, Mar 22, 2009 at 18:49, R. David Murray <span dir="ltr"><<a href="mailto:rdmurray@bitdance.com">rdmurray@bitdance.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Instead of looking at a bunch of issues last week the way I'd originally<br>
intended, I wound up doing a review of a particular patch submission,<br>
issue 2170. This is a refactoring of the 'normalize' method of<br>
xml.dom.minidom. I wound up redoing the patch with a different<br>
refactoring after finding out that the submitted patch was slower than<br>
the original code. The revised patch is faster than the original code<br>
(completes in 1/2 the time of the original code when run on a decent<br>
sized document that needed no normalization done).<br>
<br>
I think the issue stage should be set to 'patch review', as in, it is ready<br>
for developer review. The author of the original patch has reviewed my<br>
revised patch and concurs. The patch includes additional tests.<br>
</blockquote><div><br>I have set the stage.<br> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
Now that I've learned more about how the tracker is organized, and read<br>
the most-helpful <a href="http://www.python.org/dev/workflow/" target="_blank">http://www.python.org/dev/workflow/</a> document, I would<br>
be happy to go through and triage issues for which that hasn't yet been<br>
done, if I can be given permission to do so.<font color="#888888"></font></blockquote><div><br>Done!<br><br>-Brett<br></div></div><br>