<br><br><div class="gmail_quote">On Sat, Jul 23, 2011 at 20:35, Eli Bendersky <span dir="ltr"><<a href="mailto:eliben@gmail.com">eliben@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Some background: I'm working (on and off) on issue 11015 - documenting<br>
the public functions in test.support<br>
<br>
Some of the functions in test.support (for example unlink, rmtree)<br>
simply shadow existing & popular stdlib functions, with the aim of<br>
swallowing the exceptions these may throw. This is confusing, IMHO.<br>
For example, grepping 'unlink' on Lib/test/test_*.py files doesn't say<br>
much about which unlink is being used.<br>
<br>
A couple of options to handle this are:<br>
<br>
1. Remove these functions altogether, trying to use existing<br>
constructs (such as the ignore_errors parameter in rmtree).<br>
2. Adapt a naming convention for such functions, for instance<br>
rmtree_silent and unlink_silent (or a similar convention, if one<br>
exists)<br>
<br>
Opinions?<br></blockquote><div><br>The mere fact that these functions exist in a different module suggests different semantics from those found in other places in the stdlib. I don't think they should be renamed simply because some code imports the functions directly instead of the module itself (suggesting they should be doing the latter over the former). Now if the functions are redundant that's something else entirely and removal should be fine.<br>
</div></div>