<div dir="ltr"><br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div class="im">> 2. Some functions like unlink and rmtree are obviously redundant, and shadow<br>
> frequently used Python stdlib functions, so I would either kill them<br>
> completely or at least rename them appropriately.<br>
<br>
</div>But they aren't redundant, since the test.support versions ignore<br>
errors.<br></blockquote><div><br>As I mentioned elsewhere, it's not good practice to have two functions with the same name doing something slightly different, in different modules in the code-base.<br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br>
Perhaps what we could do is move the documentation for test.support to<br>
the devguide, and then vet the test suite so that unlink and friends<br>
are always called as 'support.unlink', etc.<br>
<br></blockquote></div><br>Moving the documentation to the devguide is a good compromise between not documenting them at all and placing the documentation in a user-visible location.<br><br>What do you mean by vetting the test suite so that unlink is always taken from test.support? I suppose some tests would specifically want the original unlink's functionality. In fact, at least a few tests use os.unlink exlicitly.<br>
<br>Eli<br><br><br></div>