<div dir="ltr"><div class="gmail_quote">On Fri, Feb 17, 2012 at 05:50, Nick Coghlan <span dir="ltr"><<a href="mailto:ncoghlan@gmail.com">ncoghlan@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On Fri, Feb 17, 2012 at 2:09 AM, eli.bendersky<br>
<<a href="mailto:python-checkins@python.org">python-checkins@python.org</a>> wrote:<br>
> diff --git a/Lib/test/test_xml_etree_c.py b/Lib/test/test_xml_etree_c.py<br>
> --- a/Lib/test/test_xml_etree_c.py<br>
> +++ b/Lib/test/test_xml_etree_c.py<br>
> @@ -53,8 +53,8 @@<br>
> # actual class. In the Python version it's a class.<br>
> self.assertNotIsInstance(cET.Element, type)<br>
><br>
> - def test_correct_import_cET_alias(self):<br>
> - self.assertNotIsInstance(cET_alias.Element, type)<br>
> + #def test_correct_import_cET_alias(self):<br>
> + #self.assertNotIsInstance(cET_alias.Element, type)<br>
<br>
</div>While this one was fixed quickly, *please* don't comment tests out<br>
without some kind of explanation in the code (not just in the checkin<br>
message).<br>
<br>
Even better is to use the expected_failure() decorator or the skip() decorator.<br>
<span class="HOEnZb"><font color="#888888"><a href="http://mail.python.org/mailman/listinfo/python-checkins" target="_blank"></a></font></span></blockquote><div><br>I just saw this test failing in some bots and wanted to fix it ASAP, without spending time on a real investigation. The follow-up fix came less than 2 hours later. But yes, I agree that commenting out wasn't a good choice - I should've just deleted it for the time I was working on a fix.<br>
<br>By the way, I later discussed the failing test with Florent and <a href="http://bugs.python.org/issue14035">http://bugs.python.org/issue14035</a> is the result. That failure had made no sense until Florent got deeper into import_fresh_module.<br>
<br>Eli<br><br><br><br> </div></div><br></div>