<br><br><div class="gmail_quote">On Fri, Jul 20, 2012 at 4:12 PM, Antoine Pitrou <span dir="ltr"><<a href="mailto:solipsis@pitrou.net" target="_blank">solipsis@pitrou.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On Fri, 20 Jul 2012 20:49:03 +0200 (CEST)<br>
brett.cannon <<a href="mailto:python-checkins@python.org">python-checkins@python.org</a>> wrote:<br>
> diff --git a/Lib/importlib/test/__init__.py b/Lib/test/test_importlib/__init__.py<br>
> rename from Lib/importlib/test/__init__.py<br>
> rename to Lib/test/test_importlib/__init__.py<br>
> --- a/Lib/importlib/test/__init__.py<br>
> +++ b/Lib/test/test_importlib/__init__.py<br>
> @@ -1,5 +1,6 @@<br>
> import os<br>
> import sys<br>
> +from .. import support<br>
<br>
</div>I don't know if I'm only speaking for myself, but I really have trouble<br>
parsing non-trivial relative imports,</blockquote><div><br></div><div>I obviously don't, but then again I would hope I of all people could comprehend them after all this time. =)</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
and I personally prefer when<br>
people use absolute imports (e.g. "from test import support").<br>
<br></blockquote><div><br></div><div>So I changed the import above, but I'm not going to go through and change every other relative import that stays within test.test_importlib. I'm fine if someone else wants to change them, but I leave that as an exercise for the reader.</div>
<div><br></div><div>-Brett</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
cheers<br>
<span class="HOEnZb"><font color="#888888"><br>
Antoine.<br>
<br>
<br>
--<br>
Software development and contracting: <a href="http://pro.pitrou.net" target="_blank">http://pro.pitrou.net</a><br>
<br>
<br>
_______________________________________________<br>
Python-Dev mailing list<br>
<a href="mailto:Python-Dev@python.org">Python-Dev@python.org</a><br>
<a href="http://mail.python.org/mailman/listinfo/python-dev" target="_blank">http://mail.python.org/mailman/listinfo/python-dev</a><br>
Unsubscribe: <a href="http://mail.python.org/mailman/options/python-dev/brett%40python.org" target="_blank">http://mail.python.org/mailman/options/python-dev/brett%40python.org</a><br>
</font></span></blockquote></div><br>