<html dir="ltr">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<meta name="GENERATOR" content="MSHTML 9.00.8112.16447">
<style id="owaParaStyle">P {
MARGIN-TOP: 0px; MARGIN-BOTTOM: 0px
}
</style>
</head>
<body fPStyle="1" ocsi="0">
<div style="direction: ltr;font-family: Tahoma;color: #000000;font-size: 10pt;">
<p>I was hit by this today.</p>
<p>in test_hashlib.py there is this:</p>
<p> </p>
<font color="#0000ff" size="2" face="Consolas"><font color="#0000ff" size="2" face="Consolas"><font color="#0000ff" size="2" face="Consolas">
<p>def</font></font></font><font size="2" face="Consolas"><font size="2" face="Consolas"> test_unknown_hash</font></font><font color="#008080" size="2" face="Consolas"><font color="#008080" size="2" face="Consolas"><font color="#008080" size="2" face="Consolas">(</font></font></font><font size="2" face="Consolas"><font size="2" face="Consolas">self</font></font><font color="#008080" size="2" face="Consolas"><font color="#008080" size="2" face="Consolas"><font color="#008080" size="2" face="Consolas">):</p>
</font></font></font><font size="2" face="Consolas"><font size="2" face="Consolas">
<p> self</font></font><font color="#0000ff" size="2" face="Consolas"><font color="#0000ff" size="2" face="Consolas"><font color="#0000ff" size="2" face="Consolas">.</font></font></font><font size="2" face="Consolas"><font size="2" face="Consolas">assertRaises</font></font><font color="#008080" size="2" face="Consolas"><font color="#008080" size="2" face="Consolas"><font color="#008080" size="2" face="Consolas">(</font></font></font><font size="2" face="Consolas"><font size="2" face="Consolas">ValueError</font></font><font color="#008080" size="2" face="Consolas"><font color="#008080" size="2" face="Consolas"><font color="#008080" size="2" face="Consolas">,</font></font></font><font size="2" face="Consolas"><font size="2" face="Consolas">
hashlib</font></font><font color="#0000ff" size="2" face="Consolas"><font color="#0000ff" size="2" face="Consolas"><font color="#0000ff" size="2" face="Consolas">.</font></font></font><font size="2" face="Consolas"><font size="2" face="Consolas">new</font></font><font color="#008080" size="2" face="Consolas"><font color="#008080" size="2" face="Consolas"><font color="#008080" size="2" face="Consolas">,</font></font></font><font size="2" face="Consolas"><font size="2" face="Consolas">
</font></font><font color="#a31515" size="2" face="Consolas"><font color="#a31515" size="2" face="Consolas"><font color="#a31515" size="2" face="Consolas">'spam spam spam spam spam'</font></font></font><font color="#008080" size="2" face="Consolas"><font color="#008080" size="2" face="Consolas"><font color="#008080" size="2" face="Consolas">)</p>
</font></font></font><font size="2" face="Consolas"><font size="2" face="Consolas">
<p><font style="BACKGROUND-COLOR: #ffff00"> self</font></font></font><font style="BACKGROUND-COLOR: #ffff00"><font color="#0000ff" size="2" face="Consolas"><font color="#0000ff" size="2" face="Consolas"><font color="#0000ff" size="2" face="Consolas">.</font></font></font><font size="2" face="Consolas"><font size="2" face="Consolas">assertRaises</font></font><font color="#008080" size="2" face="Consolas"><font color="#008080" size="2" face="Consolas"><font color="#008080" size="2" face="Consolas">(</font></font></font><font size="2" face="Consolas"><font size="2" face="Consolas">TypeError</font></font><font color="#008080" size="2" face="Consolas"><font color="#008080" size="2" face="Consolas"><font color="#008080" size="2" face="Consolas">,</font></font></font><font size="2" face="Consolas"><font size="2" face="Consolas">
hashlib</font></font><font color="#0000ff" size="2" face="Consolas"><font color="#0000ff" size="2" face="Consolas"><font color="#0000ff" size="2" face="Consolas">.</font></font></font><font size="2" face="Consolas"><font size="2" face="Consolas">new</font></font><font color="#008080" size="2" face="Consolas"><font color="#008080" size="2" face="Consolas"><font color="#008080" size="2" face="Consolas">,</font></font></font><font size="2" face="Consolas"><font size="2" face="Consolas">
1</font></font><font color="#008080" size="2" face="Consolas"><font color="#008080" size="2" face="Consolas"><font color="#008080" size="2" face="Consolas">)</font></font></font></font></p>
<p><font color="#008080" size="2" face="Consolas"><font color="#008080" size="2" face="Consolas"><font color="#008080" size="2" face="Consolas"></font></font></font> </p>
<p>but in hashlib.py, there is this code:</p>
<p> </p>
<font size="2" face="Consolas"><font size="2" face="Consolas">
<p></font></font><font color="#0000ff" size="2" face="Consolas"><font color="#0000ff" size="2" face="Consolas"><font color="#0000ff" size="2" face="Consolas">except</font></font></font><font size="2" face="Consolas"><font size="2" face="Consolas"> ImportError</font></font><font color="#008080" size="2" face="Consolas"><font color="#008080" size="2" face="Consolas"><font color="#008080" size="2" face="Consolas">:</p>
</font></font></font><font size="2" face="Consolas"><font size="2" face="Consolas">
<p></font></font><font color="#0000ff" size="2" face="Consolas"><font color="#0000ff" size="2" face="Consolas"><font color="#0000ff" size="2" face="Consolas"> pass</font></font></font><font size="2" face="Consolas"><font size="2" face="Consolas">
</font></font><font color="#008000" size="2" face="Consolas"><font color="#008000" size="2" face="Consolas"><font color="#008000" size="2" face="Consolas"># no extension module, this hash is unsupported.</p>
</font></font></font><font size="2" face="Consolas"><font size="2" face="Consolas">
<p></font></font><font color="#0000ff" size="2" face="Consolas"><font color="#0000ff" size="2" face="Consolas"><font color="#0000ff" size="2" face="Consolas">raise</font></font></font><font size="2" face="Consolas"><font size="2" face="Consolas"> ValueError</font></font><font color="#008080" size="2" face="Consolas"><font color="#008080" size="2" face="Consolas"><font color="#008080" size="2" face="Consolas">(</font></font></font><font color="#a31515" size="2" face="Consolas"><font color="#a31515" size="2" face="Consolas"><font color="#a31515" size="2" face="Consolas">'unsupported
hash type %s'</font></font></font><font size="2" face="Consolas"><font size="2" face="Consolas">
</font></font><font color="#008080" size="2" face="Consolas"><font color="#008080" size="2" face="Consolas"><font color="#008080" size="2" face="Consolas">%</font></font></font><font size="2" face="Consolas"><font size="2" face="Consolas"> name</font></font><font color="#008080" size="2" face="Consolas"><font color="#008080" size="2" face="Consolas"><font color="#008080" size="2" face="Consolas">)</p>
</font></font></font>
<p> </p>
<p><font color="#008080" size="2" face="Consolas"><font color="#008080" size="2" face="Consolas"><font color="#008080" size="2" face="Consolas"><font style="BACKGROUND-COLOR: #ffff00"></font></font></font></font> </p>
<p>The code will raise ValueError when int(1) is passed in, but the unittests expect a TypeError.</p>
<p>So, which is correct?</p>
<p> </p>
<p>K</p>
</div>
</body>
</html>