<div dir="ltr"><div><div><div>I presume the issue here is that Hg is so complicated that everyone knows a different subset of the commands and semantics.<br><br></div>I personally don't know what the commands for cherry-picking a revision would be.<br><br></div>I also don't know exactly what happens when you merge a PR using bitbucket. (I'm only familiar with the GitHub PR flow, and I don't like its behavior, which seems to always create an extra merge revision for what I consider as logically a single commit.)<br><br></div>BTW When I go to <a href="https://bitbucket.org/larry/cpython350">https://bitbucket.org/larry/cpython350</a> the first thing I see (in a very big bold font) is "This is Python version 3.6.0 alpha 1". What's going on here? It doesn't inspire confidence.<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Aug 16, 2015 at 10:13 AM, Larry Hastings <span dir="ltr"><<a href="mailto:larry@hastings.org" target="_blank">larry@hastings.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
<br>
<br>
So far I've accepted two pull requests into
<a href="http://bitbucket.com/larry/cpython350" target="_blank">bitbucket.com/larry/cpython350</a> in the 3.5 branch, what will become
3.5.0rc2. As usual, it's the contributor's responsibility to merge
forward; if their checkin goes in to 3.5, it's their responsibility
to also merge it into the <a href="http://hg.python.org/cpython" target="_blank">hg.python.org/cpython</a> 3.5 branch (which
will be 3.5.1) and default branch (which right now is 3.6).<br>
<br>
But... what's the plan here? I didn't outline anything specific, I
just assumed we'd do the normal thing, pulling from 3.5.0 into 3.5.1
and merging. But of the two pull requests so far accepted, one was
merged this way, though it cherry-picked the revision (skipping the
pull request merge revision Bitbucket created), and one was checked
in to 3.5.1 directly (no merging).<br>
<br>
I suppose we can do whatever we like. But it'd be helpful if we
were consistent. I can suggest three approaches:<br>
<ol>
<li>After your push request is merged, you cherry-pick your
revision from <a href="http://bitbucket.com/larry/cpython350" target="_blank">bitbucket.com/larry/cpython350</a> into
<a href="http://hg.python.org/cpython" target="_blank">hg.python.org/cpython</a> and merge. After 3.5.0 final is released
I do a big null merge from <a href="http://bitbucket.com/larry/cpython350" target="_blank">bitbucket.com/larry/cpython350</a> into
<a href="http://hg.python.org/cpython" target="_blank">hg.python.org/cpython</a>.</li>
<li>After your push request is merged, you manually check in a new
equivalent revision into <a href="http://hg.python.org/cpython" target="_blank">hg.python.org/cpython</a> in the 3.5
branch. No merging necessary because from Mercurial's
perspective it's unrelated to the revision I accepted. After
3.5.0 final is released I do a big null merge from
<a href="http://bitbucket.com/larry/cpython350" target="_blank">bitbucket.com/larry/cpython350</a> into <a href="http://hg.python.org/cpython" target="_blank">hg.python.org/cpython</a>.</li>
<li>After your push request is merged, you pull from
<a href="http://bitbucket.com/larry/cpython350" target="_blank">bitbucket.com/larry/cpython350</a> into <a href="http://hg.python.org/cpython" target="_blank">hg.python.org/cpython</a> and
merge into 3.5. In this version I don't have to do a final null
merge!<br>
</li>
</ol>
I'd prefer 3; that's what we normally do, and that's what I was
expecting. So far people have done 1 and 2.<br>
<br>
Can we pick one approach and stick with it? Pretty-please?<br>
<br>
<br>
<i>/arry</i><br>
</div>
<br>_______________________________________________<br>
python-committers mailing list<br>
<a href="mailto:python-committers@python.org">python-committers@python.org</a><br>
<a href="https://mail.python.org/mailman/listinfo/python-committers" rel="noreferrer" target="_blank">https://mail.python.org/mailman/listinfo/python-committers</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature">--Guido van Rossum (<a href="http://python.org/~guido" target="_blank">python.org/~guido</a>)</div>
</div>