<div dir="ltr"><span style="font-size:small">I know you got your answer to why the change occurred, but a patch to update any outdated comments would be appreciated. :)</span><br></div><br><div class="gmail_quote"><div dir="ltr">On Thu, 17 Nov 2016 at 07:55 Ned Batchelder <<a href="mailto:ned@nedbatchelder.com">ned@nedbatchelder.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 11/17/16 10:09 AM, Cody Piersall wrote:<br class="gmail_msg">
> On Wed, Nov 16, 2016 at 6:18 PM, Ned Batchelder <<a href="mailto:ned@nedbatchelder.com" class="gmail_msg" target="_blank">ned@nedbatchelder.com</a>> wrote:<br class="gmail_msg">
>> When I added Python 3.6 support to coverage.py, I posted a Mac wheel to<br class="gmail_msg">
>> PyPI: <a href="https://pypi.python.org/pypi/coverage/" rel="noreferrer" class="gmail_msg" target="_blank">https://pypi.python.org/pypi/coverage/</a>  That wheel was built<br class="gmail_msg">
>> against 3.6a3, the latest version at the time.  When I use it now on<br class="gmail_msg">
>> 3.6b3, it doesn't work right.  The reason is that the co_firstlineno<br class="gmail_msg">
>> field in PyCodeObject moved in September, as part of the PEP 523 work:<br class="gmail_msg">
>> <a href="https://github.com/python/cpython/commit/f1e6d88b3ca2b56d51d87b6b38ea1870c5d9490c" rel="noreferrer" class="gmail_msg" target="_blank">https://github.com/python/cpython/commit/f1e6d88b3ca2b56d51d87b6b38ea1870c5d9490c</a><br class="gmail_msg">
>><br class="gmail_msg">
>> The docs say that PyCodeObject can change at any time, but I don't see<br class="gmail_msg">
>> why the field had to move in the first place.  Was this needed?<br class="gmail_msg">
> Christian Heimes had the idea so that memory consumption wouldn't be<br class="gmail_msg">
> impacted by adding co_extra to the struct:<br class="gmail_msg">
> <a href="https://mail.python.org/pipermail/python-dev/2016-August/145961.html" rel="noreferrer" class="gmail_msg" target="_blank">https://mail.python.org/pipermail/python-dev/2016-August/145961.html</a><br class="gmail_msg">
><br class="gmail_msg">
<br class="gmail_msg">
Thanks, I should have searched :)<br class="gmail_msg">
<br class="gmail_msg">
--Ned.<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
Python-Dev mailing list<br class="gmail_msg">
<a href="mailto:Python-Dev@python.org" class="gmail_msg" target="_blank">Python-Dev@python.org</a><br class="gmail_msg">
<a href="https://mail.python.org/mailman/listinfo/python-dev" rel="noreferrer" class="gmail_msg" target="_blank">https://mail.python.org/mailman/listinfo/python-dev</a><br class="gmail_msg">
Unsubscribe: <a href="https://mail.python.org/mailman/options/python-dev/brett%40python.org" rel="noreferrer" class="gmail_msg" target="_blank">https://mail.python.org/mailman/options/python-dev/brett%40python.org</a><br class="gmail_msg">
</blockquote></div>