<div dir="auto">On second thought I don't care that much.</div><div class="gmail_extra"><br><div class="gmail_quote">On Dec 3, 2017 9:07 AM, "Eric V. Smith" <<a href="mailto:eric@trueblade.com">eric@trueblade.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 12/3/2017 11:56 AM, Guido van Rossum wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Not sure I like that better. It's an open-ended sequence of homogeneous types. What's the advantage of a tuple? I don't want to blindly follow existing APIs.<br>
</blockquote>
<br>
So people don't modify it, but consenting adults would say "don't do that". I currently return a new tuple in each call to fields(), but in the future I might return the same one every time (per class).<br>
<br>
I really don't care so much. The only reason I made any change was because the implementation was returning an OrderedDict, so I was changing the tests anyway. I'm happy to change it back to a list, based on the convention of homogeneous types being in a list.<br>
<br>
Eric.<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
On Sun, Dec 3, 2017 at 6:55 AM, Eric V. Smith <<a href="mailto:eric@trueblade.com" target="_blank">eric@trueblade.com</a> <mailto:<a href="mailto:eric@trueblade.com" target="_blank">eric@trueblade.com</a>>> wrote:<br>
<br>
  I've made a minor change: the return type of fields() is now a<br>
  tuple, it was a list.<br>
<br>
  Eric.<br>
<br>
  On 12/2/2017 9:02 AM, Eric V. Smith wrote:<br>
<br>
    I've pushed another version of PEP 557. The only difference is<br>
    changing the default value of "order" to False instead of True.<br>
    This matches regular classes: instances can be tested for<br>
    equality, but are unordered.<br>
<br>
    Discussion at<br>
    <a href="https://github.com/ericvsmith/dataclasses/issues/104" rel="noreferrer" target="_blank">https://github.com/ericvsmith/<wbr>dataclasses/issues/104</a><br>
    <<a href="https://github.com/ericvsmith/dataclasses/issues/104" rel="noreferrer" target="_blank">https://github.com/ericvsmith<wbr>/dataclasses/issues/104</a>><br>
<br>
    It's already available at<br>
    <a href="https://www.python.org/dev/peps/pep-0557/" rel="noreferrer" target="_blank">https://www.python.org/dev/pep<wbr>s/pep-0557/</a><br>
    <<a href="https://www.python.org/dev/peps/pep-0557/" rel="noreferrer" target="_blank">https://www.python.org/dev/pe<wbr>ps/pep-0557/</a>><br>
<br>
    I've updated the implementation on PyPI to reflect this change:<br>
    <a href="https://pypi.python.org/pypi/dataclasses/0.3" rel="noreferrer" target="_blank">https://pypi.python.org/pypi/d<wbr>ataclasses/0.3</a><br>
    <<a href="https://pypi.python.org/pypi/dataclasses/0.3" rel="noreferrer" target="_blank">https://pypi.python.org/pypi/<wbr>dataclasses/0.3</a>><br>
<br>
    Eric.<br>
    ______________________________<wbr>_________________<br>
    Python-Dev mailing list<br>
    <a href="mailto:Python-Dev@python.org" target="_blank">Python-Dev@python.org</a> <mailto:<a href="mailto:Python-Dev@python.org" target="_blank">Python-Dev@python.org</a>><br>
    <a href="https://mail.python.org/mailman/listinfo/python-dev" rel="noreferrer" target="_blank">https://mail.python.org/mailma<wbr>n/listinfo/python-dev</a><br>
    <<a href="https://mail.python.org/mailman/listinfo/python-dev" rel="noreferrer" target="_blank">https://mail.python.org/mailm<wbr>an/listinfo/python-dev</a>><br>
    Unsubscribe:<br>
    <a href="https://mail.python.org/mailman/options/python-dev/eric%2Ba-python-dev%40trueblade.com" rel="noreferrer" target="_blank">https://mail.python.org/mailma<wbr>n/options/python-dev/eric%2Ba-<wbr>python-dev%40trueblade.com</a><br>
    <<a href="https://mail.python.org/mailman/options/python-dev/eric%2Ba-python-dev%40trueblade.com" rel="noreferrer" target="_blank">https://mail.python.org/mailm<wbr>an/options/python-dev/eric%<wbr>2Ba-python-dev%40trueblade.com</a><wbr>><br>
<br>
<br>
<br>
  ______________________________<wbr>_________________<br>
  Python-Dev mailing list<br>
  <a href="mailto:Python-Dev@python.org" target="_blank">Python-Dev@python.org</a> <mailto:<a href="mailto:Python-Dev@python.org" target="_blank">Python-Dev@python.org</a>><br>
  <a href="https://mail.python.org/mailman/listinfo/python-dev" rel="noreferrer" target="_blank">https://mail.python.org/mailma<wbr>n/listinfo/python-dev</a><br>
  <<a href="https://mail.python.org/mailman/listinfo/python-dev" rel="noreferrer" target="_blank">https://mail.python.org/mailm<wbr>an/listinfo/python-dev</a>><br>
  Unsubscribe:<br>
  <a href="https://mail.python.org/mailman/options/python-dev/guido%40python.org" rel="noreferrer" target="_blank">https://mail.python.org/mailma<wbr>n/options/python-dev/guido%<wbr>40python.org</a> <<a href="https://mail.python.org/mailman/options/python-dev/guido%40python.org" rel="noreferrer" target="_blank">https://mail.python.org/mailm<wbr>an/options/python-dev/guido%<wbr>40python.org</a>><br>
<br>
<br>
<br>
<br>
-- <br>
--Guido van Rossum (<a href="http://python.org/~guido" rel="noreferrer" target="_blank">python.org/~guido</a> <<a href="http://python.org/%7Eguido" rel="noreferrer" target="_blank">http://python.org/%7Eguido</a>>)<br>
</blockquote>
<br>
</blockquote></div></div>