<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_quote"><div dir="ltr">On Tue, Jun 19, 2018 at 2:56 PM Jeroen Demeyer <<a href="mailto:J.Demeyer@ugent.be">J.Demeyer@ugent.be</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 2018-06-18 16:55, INADA Naoki wrote:<br>
> Speeding up most python function and some bultin functions was very<br>
> significant.<br>
> But I doubt making some 3rd party call 20% faster can make real<br>
> applications significant faster.<br>
<br>
These two sentences are almost contradictory. I find it strange to claim <br>
that a given optimization was "very significant" in specific cases while <br>
saying that the same optimization won't matter in other cases.<br></blockquote><div><br></div><div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">It's not <span style="font-family:sans-serif;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">contradictory because there </span>is basis:</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">  In most real world Python application, number of calling Python methods or</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">  bulitin functions are much more than other calls.</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">For example, optimization for bulitin `tp_init` or `tp_new` by FASTCALL was</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">rejected because it's implementation is complex and it's performance gain is</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">not significant enough on macro benchmarks.</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">And I doubt number of 3rd party calls are much more than calling builtin tp_init or tp_new.</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Of course, current benchmark suite [1] doesn't cover all types of real world Python</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">application.  You can create pull request which add benchmark for real world</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">application which depends on massive 3rd party calls.</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">[1] <a href="https://github.com/python/performance">https://github.com/python/performance</a></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Regards,</div><div>-- <br></div></div><div dir="ltr" class="gmail_signature">INADA Naoki  <<a href="mailto:songofacandy@gmail.com" target="_blank">songofacandy@gmail.com</a>></div></div>