<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_quote"><div dir="ltr">On Tue, Jun 26, 2018 at 8:46 PM Jeroen Demeyer <<a href="mailto:J.Demeyer@ugent.be">J.Demeyer@ugent.be</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 2018-06-26 13:11, Ivan Pozdeev via Python-Dev wrote:<br>
> AFAICS, your PR is not a strict improvement<br>
<br>
What does "strict improvement" even mean? Many changes are not strict <br>
improvements, but still useful to have.<br>
<br>
Inada pointed me to YAGNI <br></blockquote><div><br></div><div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">​No, YAGNI is posted by someone and they removed their comment.</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">My point was:</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote"><span style="color:rgb(36,41,46);font-family:-apple-system,system-ui,"Segoe UI",Helvetica,Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol";font-size:14px">Moving code around makes:</span><ul style="box-sizing:border-box;padding-left:2em;margin-top:0px;margin-bottom:16px;color:rgb(36,41,46);font-family:-apple-system,system-ui,"Segoe UI",Helvetica,Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol";font-size:14px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial"><li style="box-sizing:border-box;margin-left:0px">hard to track history.</li></ul><ul style="box-sizing:border-box;padding-left:2em;margin-top:0px;margin-bottom:16px;color:rgb(36,41,46);font-family:-apple-system,system-ui,"Segoe UI",Helvetica,Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol";font-size:14px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial"><li style="box-sizing:border-box;margin-top:0.25em;margin-left:0px">hard to backport patches to old branches.</li></ul></blockquote><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"> <a href="https://github.com/python/cpython/pull/7909#issuecomment-400219905">https://github.com/python/cpython/pull/7909#issuecomment-400219905</a><br></div><div class="gmail_default"><font face="arial, helvetica, sans-serif"><br></font></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">And I prefer keeping definitions relating to​ methods in methodobject.h to</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">move them to call.h only because they're used/implemented in call.c</div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
(<a href="https://en.wikipedia.org/wiki/You_aren%27t_gonna_need_it" rel="noreferrer" target="_blank">https://en.wikipedia.org/wiki/You_aren%27t_gonna_need_it</a>) but I <br>
disagree with that premise: there is a large gray zone between <br>
"completely useless" and "really needed". My PR falls in that gap of <br>
"nice to have but we can do without it".<br>
<br></blockquote><div><br></div><div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">​So I didn't think even it is "nice to have".​</div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
> You may suggest it as a supplemental PR to PEP 580. Or even a part of<br>
> it, but since the changes are controversial, better make the<br>
> refactorings into separate commits so they can be rolled back separately<br>
> if needed.<br>
<br>
If those refactorings are rejected now, won't they be rejected as part <br>
of PEP 580 also?<br></blockquote><div><br></div><div></div></div><div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Real need is important than my preference.  If it is needed PEP 580, I'm OK.</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">But I didn't know which part of the PR is required by PEP 580.</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Regards,</div><br></div>-- <br><div dir="ltr" class="gmail_signature">INADA Naoki  <<a href="mailto:songofacandy@gmail.com" target="_blank">songofacandy@gmail.com</a>></div></div>