<div dir="ltr">On 4 April 2013 12:09, Tim Chase <span dir="ltr"><<a href="mailto:python.list@tim.thechases.com" target="_blank">python.list@tim.thechases.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">On 2013-04-04 08:43, Peter Otten wrote:<br>
<div>> llanitedave wrote:<br>
>> self.mainLabel.SetFont(wx.Font(12, wx.DEFAULT, wx.NORMAL, wx.BOLD, faceName = "FreeSans"))<br>
><br>
</div><div>> I think I would prefer<br>
><br>
> labelfont = wx.Font(<br>
> pointSize=12,<br>
> style=wx.DEFAULT,<br>
> family=wx.NORMAL,<br>
> weight=wx.BOLD,<br>
> faceName="FreeSans")<br>
> self.mainLabel.SetFont(labelfont)<br>
<br>
</div>+1<br>
The only change I'd make to this suggestion would be to add a<br>
semi-superfluous comma+newline after the last keyword argument too:<br>
<div><br>
labelfont = wx.Font(<br>
pointSize=12,<br>
style=wx.DEFAULT,<br>
family=wx.NORMAL,<br>
weight=wx.BOLD,<br>
</div> faceName="FreeSans",<br>
)<br></blockquote><div><br></div><div>Since we're all showing opinions, I've always prefered the typical block indentation:</div><div><br></div><div><div>labelfont = wx.Font(<br>
pointSize=12,<br> style=wx.DEFAULT,<br> family=wx.NORMAL,<br> weight=wx.BOLD,<br></div> faceName="FreeSans",</div><div>) # Not indented here<br></div><div><br></div><div>as</div><div>
<br></div><div>A(</div><div> B(</div><div> C,</div><div> D,</div><div> E,</div><div> )</div><div>)</div><div><br></div><div>reads a lot cleaner than</div>
<div><br></div><div><div>A(</div><div> B(</div><div> C,</div><div> D,</div><div> E</div><div> )</div><div> )</div><div><br></div></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
which makes diffs cleaner when you need to insert something after<br>
faceName:<br></blockquote><div><DIFS SNIP><br></div><div><br></div><div>That is a very good point :).</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Additionally, if there are lots of keyword parameters like this, I'd<br>
be tempted to keep them in sorted order for ease of tracking them<br>
down (though CSS has long-standing arguments on how properties should<br>
be ordered, so to each their own on this).<br></blockquote><div><br></div><div>Personally I'd rarely be tempted to put more than 9 or so arguments directly into a function or class. Most of the time I can imagine unpacking (or equiv.) would look much more readable in the circumstances that apply. </div>
</div></div></div>