<div dir="ltr">Hi Danny,<div><br></div><div>I'm aware of few things that prevent merging this pull request at current state:</div><div><br></div><div>1. [VERY SIMPLE FIX] c# 6 syntax was used in this pull request, but should be downgraded to c# 4 due to .NET 4.0 and Mono.</div><div>This can be re-considered if someone is willing to look into this closer.<br><br></div><div>2. Writing unit tests for this pull request.</div><div><br></div><div>3. De-couple the fix for build script from this pull request.</div><div><br></div><div>Appveyor builds and tests were failing before, but seem to be working now.</div><div><br></div><div>If anyone is willing to finish off this pull request, then the author seems to be fine:</div><div><br></div><div><a href="https://github.com/pythonnet/pythonnet/pull/219#issuecomment-222077108">https://github.com/pythonnet/pythonnet/pull/219#issuecomment-222077108</a><br></div><div><br></div><div>Thanks,</div><div>Denis</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, May 29, 2016 at 10:34 AM, Daniel Fernandez <span dir="ltr"><<a href="mailto:fernandez_dan2@hotmail.com" target="_blank">fernandez_dan2@hotmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><div dir="ltr">Hi Denis,<div><br></div><div>I just verified that this does fix the issue with the local import in this specific case. Any idea when the pull request will be accepted?</div><div><br></div><div>Danny<br><div><hr>Date: Sat, 28 May 2016 11:55:28 -0500<br>From: <a href="mailto:denis.akhiyarov@gmail.com" target="_blank">denis.akhiyarov@gmail.com</a><br>To: <a href="mailto:pythondotnet@python.org" target="_blank">pythondotnet@python.org</a><br>Subject: Re: [Python.NET] Issue with beautifulsoup 4<br><br>There is pending pull request hopefully addressing this issue:<div><br></div><div><p style="font-size:12px;font-family:Helvetica"><span style="font-size:12pt"><a href="https://github.com/pythonnet/pythonnet/pull/219" target="_blank">https://github.com/pythonnet/pythonnet/pull/219</a></span></p><p style="font-size:12px;font-family:Helvetica"><span style="font-size:12pt"><br></span></p><p style="font-size:12px;font-family:Helvetica"><span style="font-size:12pt">If not, then please open an issue o<span></span>n github or comment on that pull request.</span></p><p style="font-size:12px;font-family:Helvetica"><span style="font-size:12pt"><br></span></p><br>On Friday, May 27, 2016, Daniel Fernandez <<a href="mailto:fernandez_dan2@hotmail.com" target="_blank">fernandez_dan2@hotmail.com</a>> wrote:<br><blockquote style="border-left:1px #ccc solid;padding-left:1ex">
<div><div dir="ltr">Hey Everyone,<div><br></div><div>I'm running into an issue importing beautifulsoup 4 only if I import clr before importing beautifulsoup. I'm using python 3.5 32-bit version on my Windows 7 and Windows 10 box. I'm using beautifulsoup package from Gohlke website (<a title="[81 KB] [Sep 29, 2015]" style="font-family:'Times New Roman';font-size:medium;color:rgb(0,0,128);text-decoration:underline;background-color:rgb(255,255,255)">beautifulsoup4-4.4.1-py3-none-any.whl)</a><br><br>I simply run</div><div>import clr</div><div>from bs4 import beautifulsoup</div><div><br></div><div>then I get this error </div><div><br></div><div><span style="color:rgb(68,68,68);font-size:15px;line-height:21.3px;background-color:rgb(255,255,255)">Unhandled Exception: System.ArgumentException: Name must not be empty!</span><br style="line-height:21.3px;color:rgb(68,68,68);font-size:15px;background-color:rgb(255,255,255)"><span style="color:rgb(68,68,68);font-size:15px;line-height:21.3px;background-color:rgb(255,255,255)"> at Python.Runtime.ModuleObject..ctor(String name)</span><br style="line-height:21.3px;color:rgb(68,68,68);font-size:15px;background-color:rgb(255,255,255)"><span style="color:rgb(68,68,68);font-size:15px;line-height:21.3px;background-color:rgb(255,255,255)"> at Python.Runtime.ModuleObject.GetAttribute(String name, Boolean guess)</span><br style="line-height:21.3px;color:rgb(68,68,68);font-size:15px;background-color:rgb(255,255,255)"><span style="color:rgb(68,68,68);font-size:15px;line-height:21.3px;background-color:rgb(255,255,255)"> at Python.Runtime.ImportHook.__import__(IntPtr self, IntPtr args, IntPtr kw)</span><br style="line-height:21.3px;color:rgb(68,68,68);font-size:15px;background-color:rgb(255,255,255)"><span style="color:rgb(68,68,68);font-size:15px;line-height:21.3px;background-color:rgb(255,255,255)"> at Python.Runtime.Runtime.PyObject_Call(IntPtr pointer, IntPtr args, IntPtr kw)</span><br style="line-height:21.3px;color:rgb(68,68,68);font-size:15px;background-color:rgb(255,255,255)"><span style="color:rgb(68,68,68);font-size:15px;line-height:21.3px;background-color:rgb(255,255,255)"> at Python.Runtime.ImportHook.__import__(IntPtr self, IntPtr args, IntPtr kw)</span><br style="line-height:21.3px;color:rgb(68,68,68);font-size:15px;background-color:rgb(255,255,255)"><span style="color:rgb(68,68,68);font-size:15px;line-height:21.3px;background-color:rgb(255,255,255)"> at Python.Runtime.Runtime.PyObject_Call(IntPtr pointer, IntPtr args, IntPtr kw)</span><br style="line-height:21.3px;color:rgb(68,68,68);font-size:15px;background-color:rgb(255,255,255)"><span style="color:rgb(68,68,68);font-size:15px;line-height:21.3px;background-color:rgb(255,255,255)"> at Python.Runtime.ImportHook.__import__(IntPtr self, IntPtr args, IntPtr kw)</span></div><div><span style="color:rgb(68,68,68);font-size:15px;line-height:21.3px;background-color:rgb(255,255,255)"><br></span></div><div><span style="color:rgb(68,68,68);font-size:15px;line-height:21.3px;background-color:rgb(255,255,255)"><br></span></div><div><font color="#444444"><span style="font-size:15px;line-height:21.3px;background-color:rgb(255,255,255)">I build the pythonnet debug version I get this call stack</span></font></div><div><font color="#444444"><span style="font-size:15px;line-height:21.3px;background-color:rgb(255,255,255)"><br></span></font></div><div><span style="background-color:rgb(255,255,255);font-size:15px;line-height:21.3px"><font color="#444444"><div>Unhandled Exception: System.ArgumentException: Name must not be empty!</div><div> at Python.Runtime.ModuleObject..ctor(String name) in pythonnet\src\runtime\moduleobject.cs:line 26</div><div> at Python.Runtime.ModuleObject.GetAttribute(String name, Boolean guess) in pythonnet\src\runtime\moduleobject.cs:line 101</div><div> at Python.Runtime.ImportHook.__import__(IntPtr self, IntPtr args, IntPtr kw) in pythonnet\src\runtime\importhook.cs:line 315</div><div> at Python.Runtime.Runtime.PyObject_Call(IntPtr pointer, IntPtr args, IntPtr kw)</div><div> at Python.Runtime.ImportHook.__import__(IntPtr self, IntPtr args, IntPtr kw) in pythonnet\src\runtime\importhook.cs:line 237</div><div> at Python.Runtime.Runtime.PyObject_Call(IntPtr pointer, IntPtr args, IntPtr kw)</div><div> at Python.Runtime.ImportHook.__import__(IntPtr self, IntPtr args, IntPtr kw) in pythonnet\src\runtime\importhook.cs:line 237</div><div><br></div><div><br></div><div>if I switch the lines of code</div><div>from bs4 import Beautifulsoup</div><div>import clr</div><div><br></div><div>no errors occur. Is anyone running into this issue?</div><div><br></div><div>Thanks.</div><div><br></div><div>Danny</div></font></span></div> </div></div>
</blockquote></div>
<br>_________________________________________________
Python.NET mailing list - <a href="mailto:PythonDotNet@python.org" target="_blank">PythonDotNet@python.org</a>
<a href="https://mail.python.org/mailman/listinfo/pythondotnet" target="_blank">https://mail.python.org/mailman/listinfo/pythondotnet</a></div></div> </div></div>
<br>_________________________________________________<br>
Python.NET mailing list - <a href="mailto:PythonDotNet@python.org">PythonDotNet@python.org</a><br>
<a href="https://mail.python.org/mailman/listinfo/pythondotnet" rel="noreferrer" target="_blank">https://mail.python.org/mailman/listinfo/pythondotnet</a><br></blockquote></div><br></div>