<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
I'm +1 for using the button when appropriate.<br>
I think it should be up to the merging person to make a call whether
a squash is a better<br>
logical unit than all the commits.<br>
I would set like a soft limit at ~5 commits or something. If your PR
has more than 5 separate<br>
big logical units, it's probably too big.<br>
<br>
The button is enabled in the settings but I can't see it.<br>
Am I being stupid?<br>
<br>
<div class="moz-cite-prefix">On 06/14/2016 06:58 AM, Joel Nothman
wrote:<br>
</div>
<blockquote
cite="mid:CAAkaFLXTyPGoB3TQXKPvb86yeX3hukAeLgSn-DJJFbOgRKw2Vw@mail.gmail.com"
type="cite">
<div dir="ltr">Sounds good to me. Thank goodness someone reads the
documentation!</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On 14 June 2016 at 19:51, Alexandre
Gramfort <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:alexandre.gramfort@telecom-paristech.fr"
target="_blank">alexandre.gramfort@telecom-paristech.fr</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex"><span
class="">> We could stop squashing during development,
and use the new Squash-and-Merge<br>
> button on GitHub.<br>
> What do you think?<br>
<br>
</span>+1<br>
<br>
the reason I see for squashing during dev is to avoid
killing the<br>
browser when reviewing. It really rarely happens though.<br>
<span class="HOEnZb"><font color="#888888"><br>
A<br>
</font></span>
<div class="HOEnZb">
<div class="h5">_______________________________________________<br>
scikit-learn mailing list<br>
<a moz-do-not-send="true"
href="mailto:scikit-learn@python.org">scikit-learn@python.org</a><br>
<a moz-do-not-send="true"
href="https://mail.python.org/mailman/listinfo/scikit-learn"
rel="noreferrer" target="_blank">https://mail.python.org/mailman/listinfo/scikit-learn</a><br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
scikit-learn mailing list
<a class="moz-txt-link-abbreviated" href="mailto:scikit-learn@python.org">scikit-learn@python.org</a>
<a class="moz-txt-link-freetext" href="https://mail.python.org/mailman/listinfo/scikit-learn">https://mail.python.org/mailman/listinfo/scikit-learn</a>
</pre>
</blockquote>
<br>
</body>
</html>