<div dir="ltr">If the dependency is really a showstopper, bundling could be an option. The module is a single, pure python file so that shouldn't complicate things much.<div><br></div><div>@Joel, regarding</div><div>«<span style="font-size:12.8px">without ndarray/sparse matrix type support, we're not going to be able to annotate most of our code in sufficient detail</span>»</div><div><br></div><div>That shouldn't be a problem, we have already written some working support for numpy at <a href="https://github.com/machinalis/mypy-data">https://github.com/machinalis/mypy-data</a>, so it's possible no annotate ndarrays and matrix types (scipy.sparse is not covered yet, I could take a look into that).</div><div><br></div><div>Best, </div><div> D.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Aug 2, 2016 at 7:12 PM, Andreas Mueller <span dir="ltr"><<a href="mailto:t3kcit@gmail.com" target="_blank">t3kcit@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><br>
<br>
On 08/02/2016 01:48 PM, Gael Varoquaux wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
* One relevant consequence is that, to add annotations on the code,<br>
scikit-learn should depend on the "typing"[1] module which contains some of the<br>
basic names imported and used in annotations. It's a stdlib module in python<br>
3.5, but the PyPI package backports it to python 2.7 and newer (I'm not sure<br>
how it works with Python 2.6, which might be an issue)<br>
</blockquote>
I am afraid that this is going to be a problem: we have a no dependency<br>
policy (beyond numpy and scipy).<br>
</blockquote></span>
I still think this is a point we should discuss further ;)<div class="HOEnZb"><div class="h5"><br>
______________________________<wbr>_________________<br>
scikit-learn mailing list<br>
<a href="mailto:scikit-learn@python.org" target="_blank">scikit-learn@python.org</a><br>
<a href="https://mail.python.org/mailman/listinfo/scikit-learn" rel="noreferrer" target="_blank">https://mail.python.org/mailma<wbr>n/listinfo/scikit-learn</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr">Daniel F. Moisset - <span style="font-size:small">UK Country Manager</span><div><a href="http://www.machinalis.com" target="_blank">www.machinalis.com</a></div><div>Skype: @dmoisset</div></div></div></div></div>
</div>