<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Ilya.<br>
<br>
You can raise an issue with multiple minor problems, or you can just
send a PR.<br>
We don't really like to do many cosmetic fixes, because they tend to
create merge conflicts.<br>
But for semantic changes, like avoiding an array copy, we're very
happy about any improvements.<br>
You can totally pack multiple one-line changes into a single PR if
they are all simple to review.<br>
One thing to keep in mind: the shorter the PR, the faster the review
and merge ;)<br>
<br>
Andy<br>
<br>
<div class="moz-cite-prefix">On 08/30/2016 03:19 PM, Ilya Persky
wrote:<br>
</div>
<blockquote
cite="mid:CAAxHhJ1hWYJTPdRvnkbbPxExcKAMqOtwekUEUxbOtnzd4bAvUw@mail.gmail.com"
type="cite">
<div dir="ltr">Hi All!
<div><br>
</div>
<div>I'm now reading scikit-learn source code and sometimes meet
minor inconsistencies here and there like unnecessary copying
of some array or some very unimportant race condition. Nothing
like serious bug really. </div>
<div><br>
</div>
<div>What should I do about it? Create an issue for each case
would be an overkill. Create an issue for all of them and add
pull request with fixes? Or first send a letter with them
here?..</div>
<div><br>
</div>
<div>Again I'm new to this code and can be easily missing
something (something looking like minor bug could appear to be
a feature :) ).</div>
<div><br>
</div>
<div>
<div>-- <br>
</div>
<div data-smartmail="gmail_signature">Thank you,<br>
Ilya.<br>
<br>
</div>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
scikit-learn mailing list
<a class="moz-txt-link-abbreviated" href="mailto:scikit-learn@python.org">scikit-learn@python.org</a>
<a class="moz-txt-link-freetext" href="https://mail.python.org/mailman/listinfo/scikit-learn">https://mail.python.org/mailman/listinfo/scikit-learn</a>
</pre>
</blockquote>
<br>
</body>
</html>