<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hi.<br>
<br>
It looks like the paper proposes two unrelated improvements, right?<br>
We don't really include algorithms that are specific for time-series
data or spatio-temporal data.<br>
How does the other improvement compare against hdbscan?<br>
<br>
There is many many different clustering algorithms out there, and I
don't think we want to implement<br>
all of them.<br>
It's not entirely clear to me when this algorithm improves over what
we have already.<br>
<br>
Btw, adding a new algorithm to scikit-learn is probably not a good
idea for a first contribution, see<br>
<a class="moz-txt-link-freetext" href="http://scikit-learn.org/dev/faq.html#how-can-i-contribute-to-scikit-learn">http://scikit-learn.org/dev/faq.html#how-can-i-contribute-to-scikit-learn</a><br>
<br>
Andy<br>
<br>
<br>
<br>
<div class="moz-cite-prefix">On 04/08/2018 09:21 AM, Manmohit Rekhi
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CA+w5oMMLBY+sBSxuR8_scDZrygtWdSf+hm5HnuRHA=8KAw2+Rg@mail.gmail.com">
<div dir="ltr">Hi Everyone,
<div><br>
</div>
<div>This is my first open source contribution and I am really
excited about scikit-learn</div>
<div>I was reading a paper on ST-DBSCAN and found that there are
no good implementations</div>
<div>of it online. </div>
<div><br>
</div>
<div>Thought this could a good opportunity to contribute. Had a
few questions before I started</div>
<div>1) Is there any problem with this algorithm being in
scikit-learn?</div>
<div>2) Is there someone already working on this algorithms?</div>
<div>3) Any things i need to take care of while
contributing(like code optimisation/libraries to be used)?</div>
<div><br>
</div>
<div>link to the paper: <a
href="https://www.sciencedirect.com/science/article/pii/S0169023X06000218"
target="_blank" moz-do-not-send="true">https://www.sciencedire<wbr>ct.com/science/article/pii/<wbr>S0169023X06000218</a></div>
<div><br>
</div>
<div>Thanks,</div>
<div>Manmohit</div>
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"></blockquote>
</div>
<br>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
scikit-learn mailing list
<a class="moz-txt-link-abbreviated" href="mailto:scikit-learn@python.org">scikit-learn@python.org</a>
<a class="moz-txt-link-freetext" href="https://mail.python.org/mailman/listinfo/scikit-learn">https://mail.python.org/mailman/listinfo/scikit-learn</a>
</pre>
</blockquote>
<br>
</body>
</html>