<html><body><div style="font-family: arial, helvetica, sans-serif; font-size: 12pt; color: #000000"><div>+1 for the geenralization of kw arguments. <br></div><div>This is obviously relevant for __init__ methods, why good old (X,y) should remain positional.<br data-mce-bogus="1"></div><div>Best,<br data-mce-bogus="1"></div><div>Bertrand<br data-mce-bogus="1"></div><div><br></div><hr id="zwchr" data-marker="__DIVIDER__"><div data-marker="__HEADERS__"><blockquote style="border-left:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;"><b>De: </b>"Joel Nothman" <joel.nothman@gmail.com><br><b>À: </b>"Scikit-learn mailing list" <scikit-learn@python.org><br><b>Envoyé: </b>Lundi 16 Septembre 2019 15:28:57<br><b>Objet: </b>Re: [scikit-learn] Vote on SLEP009: keyword only arguments<br></blockquote></div><div data-marker="__QUOTED_TEXT__"><blockquote style="border-left:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;"><div dir="ltr">Btw, consensus is defined by 2/3 of cast votes by core devs, according to our Governance. <a href="https://scikit-learn.org/dev/about.html#authors" target="_blank">https://scikit-learn.org/dev/about.html#authors</a> lists 20 core devs.<br><div>That is, we could consider this resolved after 14 votes in favour.<br><div>So far, if I've interpreted correctly:</div><br><div>+1 (adrin, nicolas, hanmin, joel, guillaume, jeremie, thomas, vlad, roman) = 9.<br></div><br><div>I've not understood a clear position from Alex. I'm assuming Andreas is in favour given his comments elsewhere, but we've not seen comment here.<br><br></div></div><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, 16 Sep 2019 at 20:06, Roman Yurchak <<a href="mailto:rth.yurchak@gmail.com" target="_blank">rth.yurchak@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">+1 assuming we are careful about continuing to allow some frequently <br>
used positional arguments, even in __init__.<br>
<br>
For instance,<br>
<br>
n_components = 10<br>
pca = PCA(n_components)<br>
<br>
is still more readable, I think, than,<br>
<br>
pca = PCA(n_components=n_components)<br>
<br>
<br>
-- <br>
Roman<br>
<br>
On 15/09/2019 00:21, Thomas J Fan wrote:<br>
> +1 from me<br>
> <br>
> On Sat, Sep 14, 2019 at 8:12 AM Joel Nothman <<a href="mailto:joel.nothman@gmail.com" target="_blank">joel.nothman@gmail.com</a> <br>
> <mailto:<a href="mailto:joel.nothman@gmail.com" target="_blank">joel.nothman@gmail.com</a>>> wrote:<br>
> <br>
> I am +1 for this change.<br>
> <br>
> I agree that users will accommodate the syntax sooner or later.<br>
> <br>
> On Fri., 13 Sep. 2019, 7:54 pm Jeremie du Boisberranger,<br>
> <<a href="mailto:jeremie.du-boisberranger@inria.fr" target="_blank">jeremie.du-boisberranger@inria.fr</a><br>
> <mailto:<a href="mailto:jeremie.du-boisberranger@inria.fr" target="_blank">jeremie.du-boisberranger@inria.fr</a>>> wrote:<br>
> <br>
> I don't know what is the policy about a sklearn 1.0 w.r.t api<br>
> changes.<br>
> <br>
> If it's meant to be a special release with possible api changes<br>
> without deprecation cycles, I think this change is a good<br>
> candidate for 1.0<br>
> <br>
> <br>
> Otherwise I'm +1 and agree with Guillaume, people will get used<br>
> to it by using it.<br>
> <br>
> Jérémie<br>
> <br>
> <br>
> <br>
> On 12/09/2019 10:06, Guillaume Lemaître wrote:<br>
>> To the question: do we want to utilise Python 3's<br>
>> force-keyword-argument syntax<br>
>> and to change existing APIs which support arguments<br>
>> positionally to use this<br>
>> syntax, via a deprecation period?<br>
>><br>
>> I am +1.<br>
>><br>
>> IMO, even if the syntax might be unknown, it will remain<br>
>> unknown until projects<br>
>> from the ecosystem are not using it.<br>
>><br>
>> To the question: which methods should be impacted?<br>
>><br>
>> I think we should be as gentle as possible at first. I am a<br>
>> little concerned about<br>
>> breaking some codes which were working fine before.<br>
>><br>
>> On Thu, 12 Sep 2019 at 04:43, Joel Nothman<br>
>> <<a href="mailto:joel.nothman@gmail.com" target="_blank">joel.nothman@gmail.com</a> <mailto:<a href="mailto:joel.nothman@gmail.com" target="_blank">joel.nothman@gmail.com</a>>> wrote:<br>
>><br>
>> These there details of specific API changes to be decided:<br>
>><br>
>> The question being put, as per the SLEP, is:<br>
>> do we want to utilise Python 3's force-keyword-argument syntax<br>
>> and to change existing APIs which support arguments<br>
>> positionally to use this syntax, via a deprecation period?<br>
>> _______________________________________________<br>
>> scikit-learn mailing list<br>
>> <a href="mailto:scikit-learn@python.org" target="_blank">scikit-learn@python.org</a> <mailto:<a href="mailto:scikit-learn@python.org" target="_blank">scikit-learn@python.org</a>><br>
>> <a href="https://mail.python.org/mailman/listinfo/scikit-learn" rel="noreferrer" target="_blank">https://mail.python.org/mailman/listinfo/scikit-learn</a><br>
>><br>
>><br>
>><br>
>> -- <br>
>> Guillaume Lemaitre<br>
>> INRIA Saclay - Parietal team<br>
>> Center for Data Science Paris-Saclay<br>
>> <a href="https://glemaitre.github.io/" rel="noreferrer" target="_blank">https://glemaitre.github.io/</a><br>
>><br>
>> _______________________________________________<br>
>> scikit-learn mailing list<br>
>> <a href="mailto:scikit-learn@python.org" target="_blank">scikit-learn@python.org</a> <mailto:<a href="mailto:scikit-learn@python.org" target="_blank">scikit-learn@python.org</a>><br>
>> <a href="https://mail.python.org/mailman/listinfo/scikit-learn" rel="noreferrer" target="_blank">https://mail.python.org/mailman/listinfo/scikit-learn</a><br>
> _______________________________________________<br>
> scikit-learn mailing list<br>
> <a href="mailto:scikit-learn@python.org" target="_blank">scikit-learn@python.org</a> <mailto:<a href="mailto:scikit-learn@python.org" target="_blank">scikit-learn@python.org</a>><br>
> <a href="https://mail.python.org/mailman/listinfo/scikit-learn" rel="noreferrer" target="_blank">https://mail.python.org/mailman/listinfo/scikit-learn</a><br>
> <br>
> _______________________________________________<br>
> scikit-learn mailing list<br>
> <a href="mailto:scikit-learn@python.org" target="_blank">scikit-learn@python.org</a> <mailto:<a href="mailto:scikit-learn@python.org" target="_blank">scikit-learn@python.org</a>><br>
> <a href="https://mail.python.org/mailman/listinfo/scikit-learn" rel="noreferrer" target="_blank">https://mail.python.org/mailman/listinfo/scikit-learn</a><br>
> <br>
> <br>
> _______________________________________________<br>
> scikit-learn mailing list<br>
> <a href="mailto:scikit-learn@python.org" target="_blank">scikit-learn@python.org</a><br>
> <a href="https://mail.python.org/mailman/listinfo/scikit-learn" rel="noreferrer" target="_blank">https://mail.python.org/mailman/listinfo/scikit-learn</a><br>
> <br>
<br>
_______________________________________________<br>
scikit-learn mailing list<br>
<a href="mailto:scikit-learn@python.org" target="_blank">scikit-learn@python.org</a><br>
<a href="https://mail.python.org/mailman/listinfo/scikit-learn" rel="noreferrer" target="_blank">https://mail.python.org/mailman/listinfo/scikit-learn</a><br>
</blockquote></div>
<br>_______________________________________________<br>scikit-learn mailing list<br>scikit-learn@python.org<br>https://mail.python.org/mailman/listinfo/scikit-learn<br></blockquote></div></div></body></html>