<div dir="ltr">It currently is set to <a href="https://github.com/scipy/scipy/pull/7814">throw an error</a>.<div><br></div><div>Eric</div><div><div><br></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Aug 31, 2017 at 2:41 PM, Phillip Feldman <span dir="ltr"><<a href="mailto:phillip.m.feldman@gmail.com" target="_blank">phillip.m.feldman@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>This is an excellent change!<br><br></div>What does the code do if the caller specifies both `fs` and `nyq`?</div><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="h5">On Wed, Aug 30, 2017 at 10:22 PM, Warren Weckesser <span dir="ltr"><<a href="mailto:warren.weckesser@gmail.com" target="_blank">warren.weckesser@gmail.com</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5"><div dir="ltr">I've been using quite a few of the functions in scipy.signal recently, and I've been reminded of some of the quirks of the API. I have submitted a pull request to clean up one of those quirks.<br><br>In the new pull request, I have added the argument 'fs' (the sampling frequency) to the following functions: firwin, firwin2, firls, and remez. For firwin, firwin2 and firls, the new argument replaces 'nyq', and for remez, it replaces 'Hz'. This makes these functions consistent with the other functions in which the sampling frequency is specified using 'fs': periodogram, welch, csd, coherence, spectrogram, stft, and istft. 'fs', or in LaTeX, $f_s$, is common notation for the sampling frequency in the DSP literature.<br><br>In the pull request, the old argument is given a "soft" deprecation. That means the docstring says the argument is deprecated, but code to actually generate a DeprecationWarning has not been added yet. I'm fine with adding that now, but some might prefer a relatively long and soft transition for these changes. (Personally, I don't mind if they hang around for a while, but they should be gone by 2.0. :)<br><br>I haven't changed the default value of the sampling frequency. For the FIR filter design functions firls, firwin and firwin2, the default is nyq=1.0 (equivalent to fs=2), while for remez the default is Hz=1 (i.e. fs=1). The functions that currently already use 'fs' all have the default fs=1. Changing the default for the FIR design functions would be a much more disruptive change.<br><br>Comments here or on the pull request are welcome.<br><br>P.S. I can see future pull requests in which 'fs' is added to functions that currently don't have an argument to specify the sampling frequency. I'm looking at you, freqz.<br><br></div>
<br></div></div><span class="">______________________________<wbr>_________________<br>
SciPy-Dev mailing list<br>
<a href="mailto:SciPy-Dev@python.org" target="_blank">SciPy-Dev@python.org</a><br>
<a href="https://mail.python.org/mailman/listinfo/scipy-dev" rel="noreferrer" target="_blank">https://mail.python.org/mailma<wbr>n/listinfo/scipy-dev</a><br>
<br></span></blockquote></div><br></div>
<br>______________________________<wbr>_________________<br>
SciPy-Dev mailing list<br>
<a href="mailto:SciPy-Dev@python.org">SciPy-Dev@python.org</a><br>
<a href="https://mail.python.org/mailman/listinfo/scipy-dev" rel="noreferrer" target="_blank">https://mail.python.org/<wbr>mailman/listinfo/scipy-dev</a><br>
<br></blockquote></div><br></div>