<div dir="ltr"><div class="gmail_extra">Hi thanks for the response<br><br><div class="gmail_quote">On Fri, Mar 15, 2013 at 5:43 PM, Hugo Arts <span dir="ltr"><<a href="mailto:hugo.yoshi@gmail.com" target="_blank">hugo.yoshi@gmail.com</a>></span> wrote:<br>
<blockquote style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204,204,204);border-left-width:1px;border-left-style:solid" class="gmail_quote"><div dir="ltr">On Fri, Mar 15, 2013 at 9:03 PM, Hugo Arts <span dir="ltr"><<a href="mailto:hugo.yoshi@gmail.com" target="_blank">hugo.yoshi@gmail.com</a>></span> wrote:<div class="gmail_extra">
<div class="gmail_quote">
<blockquote style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204,204,204);border-left-width:1px;border-left-style:solid" class="gmail_quote"><div dir="ltr"><div><div><div class="gmail_extra"><br></div>
</div></div><div class="gmail_extra">I have a few comments</div>
<div class="gmail_extra"><br></div><div class="gmail_extra">* Does the script work? If yes, I'd say it's probably fine. Pretty short so easy to understand whatever you do, and I see no obviously crazy broken s**t in there. I don't much like 'fi' and 'fo' for variable names because I have no idea what it means, but it's not a huge issue in a script this small. If anything, I'd suggest more descriptive variable names and just a tad mor </div>
</div></blockquote></div></div></div></blockquote><blockquote style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204,204,204);border-left-width:1px;border-left-style:solid" class="gmail_quote"><div dir="ltr">
<div class="gmail_extra"><div class="gmail_quote"><blockquote style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204,204,204);border-left-width:1px;border-left-style:solid" class="gmail_quote"><div dir="ltr">
<div class="gmail_extra">e use of underscores in them to make it easier on the eyes. Google PEP 8 and check it out, it's the python style guide.</div><div class="gmail_extra"> </div></div></blockquote></div></div></div>
</blockquote><div>Sure- will do that going forward. as you can see for two of the files I have gone with descriptive names. </div><blockquote style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204,204,204);border-left-width:1px;border-left-style:solid" class="gmail_quote">
<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204,204,204);border-left-width:1px;border-left-style:solid" class="gmail_quote">
<div dir="ltr"><div class="gmail_extra"> </div>
<div class="gmail_extra"><br></div><div class="gmail_extra">* I have no clue what DBRM or JCL are, and what a bind statement is. Ideally, if you could give us some examples of what your input and output looks like, I have a much better idea of what the script is trying to do.</div>
<div class="gmail_extra"> </div></div></blockquote></div></div></div></blockquote><div>I already provided the example of the "template". The other file has a list of the DBRMs like so</div><div> </div><div>bindjcldbrmlist.txt</div>
<div>BBDTMC10<br>BBLAMC06<br>BBLAMC07<br>BBLAMC16<br>BBLAMC24<br>BBLAMC25<br>BBLBMC02<br>BBMTLC01<br>E5623941<br>F0829057<br>F0829073</div><div> </div><div>Output would look like this (first 11 lines are the "fixed" part of the output)</div>
<div>//SC10D01B JOB (SCM,RBSTC),'COOLGEN',MSGCLASS=A,CLASS=P,<br>// COND=(4,LT)<br>//*<br>//BIND EXEC PGM=IKJEFT01,DYNAMNBR=50<br>//SYSTSPRT DD SYSOUT=*<br>//SYSPRINT DD SYSOUT=*<br>//DBRMLIB DD DSN=SCLM.PROD.DBRMLIB,DISP=SHR<br>
// DD DSN=SCLM.EMER.DBRMLIB,DISP=SHR<br>// DD DSN=JOYCE,DISP=SHR<br>//SYSTSIN DD *<br>DSN SYSTEM(DSN)</div><div>BIND PACKAGE(PROD) -<br>MEMBER(BBDTMC10) -<br> OWNER(SYSDB2) -<br> QUALIFIER(PRODDB2) -<br>
ISOLATION(CS) -<br> EXPLAIN(YES) -<br> ACTION(REPLACE) -<br> CURRENTDATA(YES) -<br> VALIDATE(BIND)<br>BIND PACKAGE(PROD) -<br>MEMBER(BBLAMC06) -<br> OWNER(SYSDB2) -<br> QUALIFIER(PRODDB2) -<br>
ISOLATION(CS) -<br> EXPLAIN(YES) -<br> ACTION(REPLACE) -<br> CURRENTDATA(YES) -<br> VALIDATE(BIND)</div><div>etc..etc</div><div><br> </div><blockquote style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204,204,204);border-left-width:1px;border-left-style:solid" class="gmail_quote">
<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204,204,204);border-left-width:1px;border-left-style:solid" class="gmail_quote">
<div dir="ltr"><div class="gmail_extra"> </div><div class="gmail_extra"> </div>
<div class="gmail_extra"><br></div><div class="gmail_extra">* Not knowing what version of python you have greatly limits the amount of useful advice I can give you. More modern versions support stuff like with statements to simplify file handling and the str.format function which may be very useful in your template (you could also use % style formatting, perhaps?). But if you're still on 2.5, which wouldn't surprise me on a big mainframe, you don't have the cool stuff yet.</div>
<div class="gmail_extra"> </div></div></blockquote></div></div></div></blockquote><div>I am not doing this on the mainframe. IBM mainframe doesn't have Python (at least not on z/OS), it has its own scripting language called REXX which is what I'd normally have written this in. I am doing this with Python 2.7 on windows after downloading the necessary input files from the mainframe and I'll upload the output back to the mainframe to run the job that was created <br>
</div><blockquote style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204,204,204);border-left-width:1px;border-left-style:solid" class="gmail_quote"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">
<blockquote style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204,204,204);border-left-width:1px;border-left-style:solid" class="gmail_quote"><div dir="ltr"><div class="gmail_extra">Like I said in the first point though, the script is very small and everything looks quite reasonable. It seems readable enough *if* you know what kind of input and output date it's dealing with.</div>
<div class="gmail_extra"><br></div><div class="gmail_extra">HTH,</div><div class="gmail_extra">Hugo</div></div>
</blockquote></div><br></div><div class="gmail_extra">just fyi, my previous mail to you (quoted above) was blocked by leeds learning for "unacceptable language." The only thing I could think of in it that triggered the filter is s**t (I've also censored it out above). But you might want to consider using a different address for communications with public mailing lists. We're all here on our free time volunteering to help out, and I'm not keen on going through the trouble of re-sending e-mails and censoring myself just so I can help a stranger. No bad feelings or anything, just pointing this out :)</div>
<span><font color="#888888">
<div class="gmail_extra"><br></div></font></span></div></blockquote><div>Happy to oblige, but not sure I fully understand. I'm using a gmail account and sending a mail to <a href="mailto:tutor@python.org">tutor@python.org</a> What should I be doing differently?</div>
<blockquote style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204,204,204);border-left-width:1px;border-left-style:solid" class="gmail_quote"><div dir="ltr"><span><font color="#888888"><div class="gmail_extra">
</div><div class="gmail_extra">Hugo</div></font></span></div>
</blockquote></div><br></div></div>