Sounds good to me! Until we need to expand on this system or encounter some edge-cases, I'd say we can do it this way :) Michael On 29.10.2022 21:05, BiT dev wrote:
Dear bit-team members,
I have received commit right by Germar (THX!) and just pushed my first direct commit (just changing the README file).
This brings up the question of how we collaborate in the future to assure code quality.
At least I must admit that "night shifts" do not always lead to correct and "error-free" solutions in my code ;-)
I suggest:
1. Documentation-only commits can be pushed directly
2. Code changes shall be send via PR to establish a 4-eyes principle ("review"): - Apply the "approve" workflow in PRs - Review comments are used for discussions and feed-back - A PR can be merged by an bit-team member (even by the PR opener) if - all changes are approved - discussions have stabilized without an explicit "merge veto" - In case of controverse "merge veto's" we need a way to solve this in a constructive way eg. (@emtiu as "esacalation instance" or a democratic vote)
_______________________________________________ Bit-dev mailing list -- bit-dev@python.org To unsubscribe send an email to bit-dev-leave@python.org https://mail.python.org/mailman3/lists/bit-dev.python.org/ Member address: foss@michael-bueker.de