Document weak dependencies when spawning sub processes?
I have just managed to identify a bug preventing the sys tray icon to be shown (together with the issue reporter) https://github.com/bit-team/backintime/issues/1236#issuecomment-1324079326 and it turned out that a required CLI tool (`xdpyinfo`) was not installed which is used to check if X11 is running https://github.com/bit-team/backintime/blob/713590f45cb83d1192a104ec77b73562... https://github.com/bit-team/backintime/blob/713590f45cb83d1192a104ec77b73562... I think we should work through all source files and document required CLI tools. This is not only required to prevent bugs but also for package maintainers.
A very good idea. Could this be automated? By grepping for Popen() calls maybe? Michael On 22.11.2022 20:12, BiT dev wrote:
I have just managed to identify a bug preventing the sys tray icon to be shown (together with the issue reporter)
https://github.com/bit-team/backintime/issues/1236#issuecomment-1324079326
and it turned out that a required CLI tool (`xdpyinfo`) was not installed which is used to check if X11 is running
https://github.com/bit-team/backintime/blob/713590f45cb83d1192a104ec77b73562...
https://github.com/bit-team/backintime/blob/713590f45cb83d1192a104ec77b73562...
I think we should work through all source files and document required CLI tools. This is not only required to prevent bugs but also for package maintainers.
Yes, grep would work. pycharm indicates 54 popens. The dependencies could be documented together with a fix for this issue: [Unit tests] Popen() warning: subprocess is still running (non-deterministic) https://github.com/bit-team/backintime/issues/1292 On Tue, 2022-11-22 at 20:42 +0100, Michael Büker wrote:
A very good idea. Could this be automated? By grepping for Popen() calls maybe?
Michael
On 22.11.2022 20:12, BiT dev wrote:
I have just managed to identify a bug preventing the sys tray icon to be shown (together with the issue reporter)
https://github.com/bit-team/backintime/issues/1236#issuecomment-1324079326
and it turned out that a required CLI tool (`xdpyinfo`) was not installed which is used to check if X11 is running
https://github.com/bit-team/backintime/blob/713590f45cb83d1192a104ec77b73562...
https://github.com/bit-team/backintime/blob/713590f45cb83d1192a104ec77b73562...
I think we should work through all source files and document required CLI tools. This is not only required to prevent bugs but also for package maintainers.
Bit-dev mailing list -- bit-dev@python.org To unsubscribe send an email to bit-dev-leave@python.org https://mail.python.org/mailman3/lists/bit-dev.python.org/ Member address: python@altfeld-im.de
Are we sure that only Popen() is used? Subprocess (i.e. subprocess.run()) is both very convenient and is the recommended way to do things, if I remember correctly. Cheers, Hakan On 22.11.2022 22:42, Michael Büker wrote:
A very good idea. Could this be automated? By grepping for Popen() calls maybe?
Michael
On 22.11.2022 20:12, BiT dev wrote:
I have just managed to identify a bug preventing the sys tray icon to be shown (together with the issue reporter)
https://github.com/bit-team/backintime/issues/1236#issuecomment-1324079326
and it turned out that a required CLI tool (`xdpyinfo`) was not installed which is used to check if X11 is running
https://github.com/bit-team/backintime/blob/713590f45cb83d1192a104ec77b73562...
https://github.com/bit-team/backintime/blob/713590f45cb83d1192a104ec77b73562...
I think we should work through all source files and document required CLI tools. This is not only required to prevent bugs but also for package maintainers.
Bit-dev mailing list -- bit-dev@python.org To unsubscribe send an email to bit-dev-leave@python.org https://mail.python.org/mailman3/lists/bit-dev.python.org/ Member address: hakan@bayindir.org
THX Hakan, important point. Look like I have to search for all usual suspects who may spawn a sub process in python On Wed, 2022-11-23 at 10:39 +0300, Hakan Bayındır wrote:
Are we sure that only Popen() is used? Subprocess (i.e. subprocess.run()) is both very convenient and is the recommended way to do things, if I remember correctly.
Cheers,
Hakan
On 22.11.2022 22:42, Michael Büker wrote:
A very good idea. Could this be automated? By grepping for Popen() calls maybe?
Michael
On 22.11.2022 20:12, BiT dev wrote:
I have just managed to identify a bug preventing the sys tray icon to be shown (together with the issue reporter)
https://github.com/bit-team/backintime/issues/1236#issuecomment-1324079326
and it turned out that a required CLI tool (`xdpyinfo`) was not installed which is used to check if X11 is running
https://github.com/bit-team/backintime/blob/713590f45cb83d1192a104ec77b73562...
https://github.com/bit-team/backintime/blob/713590f45cb83d1192a104ec77b73562...
I think we should work through all source files and document required CLI tools. This is not only required to prevent bugs but also for package maintainers.
Bit-dev mailing list -- bit-dev@python.org To unsubscribe send an email to bit-dev-leave@python.org https://mail.python.org/mailman3/lists/bit-dev.python.org/ Member address: hakan@bayindir.org
_______________________________________________ Bit-dev mailing list -- bit-dev@python.org To unsubscribe send an email to bit-dev-leave@python.org https://mail.python.org/mailman3/lists/bit-dev.python.org/ Member address: python@altfeld-im.de
participants (3)
-
BiT dev -
Hakan Bayındır -
Michael Büker