FAQ: "Modify for Full System Backup"
Hello Folks, there is a FAQ entry talking about a button or menu entry named "Modify for Full System Backup". I couldn't find it anywhere. Does someone can find it? Or is it gone and we can drop that FAQ entry? https://github.com/bit-team/backintime/wiki/FAQ#what-is-the-effect-of-modify... Kind Christian
Moin! According to CHANGES, it's a feature that was introduced in late 2015, and first released with 1.1.10 in 2016. It apparently came from a PR: https://github.com/bit-team/backintime/commit/16a21f613d7d67b58f938fb337f809... as a starting attempt to implement #480 (bare-metal full-system restore: https://github.com/bit-team/backintime/issues/480). A few months later, the button was hidden again, citing the fact that development was incomplete: https://github.com/bit-team/backintime/commit/dfbd4bb17c1b312a8a21c258096ddf... – judging by the commit and release dates, this was probably released with version 1.1.14. Therefore, 1.1.10 and 1.1.12 probably were the only versions ever to show that button. The feature was never fully implemented, and I would personally consider it out-of-scope for backintime (even though users frequently wish for it). I'd say it's safe and sensible to remove the feature entirely, by reverting these three commits – but there could be more commits involved, and I haven't checked for that: https://github.com/bit-team/backintime/commit/157d2b46109f7b9510db7723b3e3e7... https://github.com/bit-team/backintime/commit/16a21f613d7d67b58f938fb337f809... https://github.com/bit-team/backintime/commit/dfbd4bb17c1b312a8a21c258096ddf... Cheers, Michael On 02.12.2022 09:39, c.buhtz@posteo.jp wrote:
Hello Folks,
there is a FAQ entry talking about a button or menu entry named "Modify for Full System Backup". I couldn't find it anywhere. Does someone can find it? Or is it gone and we can drop that FAQ entry?
https://github.com/bit-team/backintime/wiki/FAQ#what-is-the-effect-of-modify...
Kind Christian
Moin Am 02.12.2022 10:52 schrieb Michael Büker:
A few months later, the button was hidden again
OK, then I removed it from the FAQ.
I'd say it's safe and sensible to remove the feature entirely, by reverting these three commits
I wouldn't recommend reverting that commits. It seems more secure to me to edit and remove that code in a new commit. We could open a new Issue for that to keep track on that task and doing it after the next release.
Moin! On 02.12.2022 11:35, c.buhtz@posteo.jp wrote:
I wouldn't recommend reverting that commits. It seems more secure to me to edit and remove that code in a new commit. We could open a new Issue for that to keep track on that task and doing it after the next release.
You're right, of course, that's what I meant. I should have used a different word than "revert" :) Michael
participants (2)
-
c.buhtz@posteo.jp
-
Michael Büker