On Mon, 3 Sep 2018 at 04:44 Victor Stinner <vstinner@redhat.com> wrote:
Le lun. 3 sept. 2018 à 13:09, Pablo Galindo Salgado <pablogsal@gmail.com> a écrit :
We use Cython a lot to wrap and test C and C++ libraries at work and is true that makes some aspects more simple and easy to express. Also you can leverage integration with other testing tools (pytest, mocks...etc) at to some extent. But I humbly think that Cython is not the best choice for this particular project. (...)
One compromise would be to use unit tests in C for the most basic tests, but use Cython for "integration" tests" and more complex tests.
I think that makes sense. The worry of unintended issues due to Cython happening to use an C API that's actually under test seems like a reasonable worry. So using Cython for higher-level stuff to make it easier when the unit tests cover the foundations makes sense to me.
I'm not against having more tests :-)
:)
One thing I wanted to mention is I noticed Check is LGPL: https://github.com/libcheck/check/blob/master/COPYING.LESSER . This might be a problem to include it in CPython's repo or in distributing the tests as part of the source for any other reason than anyone who wants to keep all copyleft code out will have to strip out the C tests.