code-quality August 2013

code-quality@python.org

12 participants
10 discussions

Something about Pylint
by 侯焯明 03 Sep '13

03 Sep '13

Hello, I am a beginner to Pylint, My name is Hou Zhuoming. When I install the pylint 1.0.0 in python 3.3(OS:Windows7), there is a error happened. And then I read the source code of pylint 1.0.0. I found something is wrong in setup.py model. Line 138: call(['2to3','-wn',dest]): I think the problem is the system cannot find 2to3. But I can find a script named '2to3.py' in my python 3.3. So I change Line 138 to: call(['C:\\Python33\\Tools\\Scripts\\2to3.py', '-wn', dest], shell=sys.platform=='win32'). It works! I can install pylint 1.0.0 successfully after the change. My setup.py in pylint 1.0.0: I found the same problem in astroid-1.0.0 and logilab-common-0.60.0 too. I also can install these two packages with the same change. I am not sure it is a bug. Maybe, something is wrong when I am installing the pylint 1.0.0. (No problem in Linux) Another problem: when I successfully installed pylint 1.0.0, I want to run the pylint-gui.exe. I can see the GUI successfully. But when I want to test some python scripts, it works wrong.(The pylint.exe works normally) All these problems happen in python 3.3(Operating system is Windows 7). I need your help. Thank you. ------------------ School of Software,Sun Yat-sen University Zhuoming Hou(侯焯明) Email:745189913@qq.com

3 6

Extending pylint to deal with template variables?
by Jonathan Eunice 30 Aug '13

30 Aug '13

I originally asked the following question on Stack Overflow<http://stackoverflow.com/questions/18500998/extending-pylint-to-deal-with-t…>. It was suggested that this would be the better venue for discussion. -- I wrote the say <https://pypi.python.org/pypi/say> module to make formatted printing simpler and more straightforward. E.g. say("{len(items)} retrieved; {n_errors} encountered") rather than: print("{0} retrieved; {1} encountered".format(len(items), n_errors)) That part is going great. But I like to run pylint to look for gotchas and mistakes. Unfortunately, many data values are constructed solely for their usefulness in output operations, and pylint cannot "see" that use in a say call (or any other templates output mechanism) constitutes a genuine use of the variable. Wave after wave of W0612 (unused-variable) warnings can result. It's possible to simply put in ignore comments, but that seems retrograde. I'd rather just extend pylint to understand that variables used in say() templates are, in fact, used. .../pylint/checkers/variables.py appears to be the place to add this check, but I'm unfamiliar with the codebase. Any hints or suggestions as to how to register variables used in format-style strings are, indeed, properly used? -- One SO commenter suggested that since pylint doesn't do much with strings, this may be a fair amount of work. But I already know how to parse format-style strings; I just use Python's own string.Formatter.parse. Creating an AST from the contents of the format braces and walking it to find what names are referenced--I've got that covered. What I most need is insight into how to communicate to pylint that it should consider the identifiers I've found to be used. I'd also seen at least one comment online suggesting that pylint doesn't really have an extensions/plugin mechanism. Is that true? Either way, what would be the best way to provide extended functionality atop pylint? Is the team receptive to code contributions?

3 2

Flake8 News
by Ian Cordasco 29 Aug '13

29 Aug '13

Hey all, I would first like to apologize for my complete disappearance from everything related to this list. Between finishing my masters, moving 1000 miles away and starting a new job (before I was even able to acquire domestic internet), I haven't had time for much of anything. In spite of that poor excuse, I'm sprinting on Flake8 today (trying to fix bugs and get other things written), and I wanted community feedback on a few things. First, is there any interest in developing a pylint plugin for Flake8? If so, who's interested in working with me on it. (I doubt we will finish it today, but I'd at least like to start it.) Second, can anyone provide some guidance (or at least opinions) on issue #85 on Flake8's bug tracker[1]. I'm conflicted about using a script to manage which version of python we use and I am quite partial to the method of appending the python version to the executable's name. However, if others have strong opinions on this, I'm quite willing to listen and would love more information. Finally, if there is anyone willing to collaborate with me on issues #95 [2], #97 [3], and #99 [4], I'd heartily appreciate it. To save you a few clicks, here are some summaries of those issues: #95: Generate code quality visualizations akin to: https://github.com/jsoverson/plato #97: Maintainability index based off McCabe, Halstead and SLOC #99: Machine readable output. This can probably take full advantage of pep8 features without needing to do anything special with Flake8. Firehose may also be of interest. [1]: https://bitbucket.org/tarek/flake8/issue/85 [2]: https://bitbucket.org/tarek/flake8/issue/95 [3]: https://bitbucket.org/tarek/flake8/issue/97 [4]: https://bitbucket.org/tarek/flake8/issue/99 Thanks in advance, Ian

6 11

logilab-common 0.60
by Skip Montanaro 27 Aug '13

27 Aug '13

I figured out my pylint install woes (I really dislike distutils). Then I needed a newer version of astroid. Picked up the latest, which was also 1.0.0. That, alas, requires logilab-common >= 0.60.0, which has yet to be released. Even the latest mercurial stuff only provides 0.58.x. Where have I gone wrong? Thx, Skip

3 7

Problems installing pylint 1.0
by Skip Montanaro 26 Aug '13

26 Aug '13

I'm trying to package up pylint 1.0 for our local installation. For the most part, the simple tar archive seems ideal, however the path components in the generated tar file have an unwanted prefix. Our Python installation is in /opt/TWWfsw/python27, so ./opt/TWWfsw/python27 appears as a prefix to all components of the tar file: % tar tfz dist/pylint-1.0.0.share.tar.gz | head ./ ./opt/ ./opt/TWWfsw/ ./opt/TWWfsw/python27/ ./opt/TWWfsw/python27/lib/ ./opt/TWWfsw/python27/lib/python2.7/ ./opt/TWWfsw/python27/lib/python2.7/site-packages/ ./opt/TWWfsw/python27/lib/python2.7/site-packages/pylint-1.0.0-py2.7.egg-info/ ./opt/TWWfsw/python27/lib/python2.7/site-packages/pylint-1.0.0-py2.7.egg-info/dependency_links.txt ./opt/TWWfsw/python27/lib/python2.7/site-packages/pylint-1.0.0-py2.7.egg-info/top_level.txt I would like that to be: % tar tfz dist/pylint-1.0.0.share.tar.gz | head ./ ./lib/ ./lib/python2.7/ ./lib/python2.7/site-packages/ ./lib/python2.7/site-packages/pylint-1.0.0-py2.7.egg-info/ ./lib/python2.7/site-packages/pylint-1.0.0-py2.7.egg-info/dependency_links.txt ./lib/python2.7/site-packages/pylint-1.0.0-py2.7.egg-info/top_level.txt How do I manage that? The bdist command doesn't accept a --prefix arg. Alternatively, I'd like the install command to work properly. It does the right thing path-wise, but only installs lib, not bin: % ls -l /var/tmp/pylint-1.0/ total 4 drwxrwxr-x 3 skipm snake 4096 Aug 6 09:44 lib Thx, Skip

2 2

Fwd: Flake8 News
by Ian Cordasco 25 Aug '13

25 Aug '13

Alexandre and I accidentally had this discussion off list. ---------- Forwarded message ---------- From: afayolle <afayolle.ml(a)free.fr> Date: Mon, Jul 15, 2013 at 3:24 AM Subject: Re: [code-quality] Flake8 News To: Ian Cordasco <graffatcolmingov(a)gmail.com> On mer. 10 juil. 2013 13:50:22 CEST, Ian Cordasco wrote: > On Jul 10, 2013 6:33 AM, "afayolle" <afayolle.ml(a)free.fr > <mailto:afayolle.ml@free.fr>> wrote: > > > > On 09/07/2013 08:36, Sylvain Thénault wrote: > > > Hi Ian, > > > > > > On 04 juillet 11:42, Ian Cordasco wrote: > > >> First, is there any interest in developing a pylint plugin for > Flake8? > > >> If so, who's interested in working with me on it. (I doubt we will > > >> finish it today, but I'd at least like to start it.) > > > On my side, I can't commit to find time to work on this but I > would definitly > > > like to have pylint integrated there and I'm willing to help > anyone working on > > > it. That would probably be a good opportunity to find common stuff > done in pylint > > > and flake8: I'm pretty sure both project may learn from each other > on high-level > > > stuff such as message control, ast handling, analysis execution... > Pylint has been > > > there for a while and has imo (truly objectivly, of course ;) neat > features on > > > that side. > > > > > > Cheers, > > > > Be aware of the licensing issue, though : depending on the way flake8 > > works (subprocess or import), the GPL license of Pylint could be an > > issue if the flake8 authors want to stick to MIT. > > > > Alexandre > > _______________________________________________ > > code-quality mailing list > > code-quality(a)python.org <mailto:code-quality@python.org> > > http://mail.python.org/mailman/listinfo/code-quality > > Thanks for that reminder and insight Alexandre! I don't remember if > that's relevant to the general idea of how we will implement this. We > would technically be blindly importing a plugin written by someone who > would be providing us with our expected interface for using pylint. > The same works for one-off plugins that do not interface with a third > party tool. Would this still affect our licensing? > It all depends on the way the plugin works. I'm not a lawyer, so take what I say with the usual caution. Here's my understanding: case 1: the plugin uses the command line API of Pylint to run Pylint in a subprocess and parses Pylint's output to implement the Flake8 api. In that case, the plugin can be under any license (e.g. MIT) case2: the plugin imports bits of the pylint code, and uses Pylint's API to do the checking and get the results. In that case the plugin must be made available under the GPL. Since the MIT license is compatible with the GPL, both the plugin and flake8 can be distributed. Alexandre

1 0

astroid and logilab-common still disagree about versions
by Skip Montanaro 22 Aug '13

22 Aug '13

I reported a couple weeks ago about astroid demanding logilab-common >= 0.60, while the latest stable branch of logilab-common insists that the latest version is just 0.58.2. I trying "hg pull ; hg update" on both repos just now and find the situation hasn't changed. I am updated to the stable branch of logilab-common and the default branch of astroid. Am I supposed to be on the stable branch of astroid? That doesn't seem right, as its __pkginfo__ module says it's only version 0.24.3 So, I'm kind of stuck, looking for a "correct" solution here. I could, in theory, mangle my __pkginfo__ modules, but that just introduces a bad hack I have to remember later. Thx, Skip

2 2

Type hinting parameters of standard library functions
by George Schneeloch 09 Aug '13

09 Aug '13

I was thinking of working on a tool which interacts with Astroid's type inference capabilities. It would either get the type hints of parameters through function annotations or from @param tags in docstrings. This would help create warnings where the parameter or something which uses it is being used in an unexpected way, inconsistent with documentation. I was wondering if there is any machine-readable information about what types functions in the standard library expect? For example, PyCharm seems to know that os.path.split cannot return a tuple of three values, so x, y, z = os.path.split("a/path/here") causes the IDE warning "needs more values to unpack". When I jump to the documentation it's described like this: def split(p) Inferred type: (p: one of (str, unicode)) -> (one of (str, unicode, unknown),one of (str, unicode, unknown)) Split a pathname. Returns tuple "(head, tail)" where "tail" is everything after the final slash. Either part may be empty. Did JetBrains (who make PyCharm) gather this information themselves, or is this kind of thing publicly available somewhere? Thanks for your help, -George

3 3

Pylint 1.0 released
by Sylvain Thénault 06 Aug '13

06 Aug '13

Hi there, at last, Pylint 1.0 is out! See http://www.logilab.org/blogentry/163292 for (much) more info and enjoy! And many thanks to every one who contributed to this release... -- Sylvain Thénault, LOGILAB, Paris (01.45.32.03.12) - Toulouse (05.62.17.16.42) Formations Python, Debian, Méth. Agiles: http://www.logilab.fr/formations Développement logiciel sur mesure: http://www.logilab.fr/services CubicWeb, the semantic web framework: http://www.cubicweb.org

1 0

Astroid 1.0 released
by Sylvain Thénault 02 Aug '13

02 Aug '13

Hi there, waiting for to-be-released soon Pylint 1.0, I think it's worth mentionning here the release of the underlying astroid library: more info on http://www.logilab.org/blogentry/158911 I hope it may be of interest for people developping python code checkers than Pylint. I'll be there to discuss about that when I'll be back from vacation in a few weeks. ++ -- Sylvain Thénault, LOGILAB, Paris (01.45.32.03.12) - Toulouse (05.62.17.16.42) Formations Python, Debian, Méth. Agiles: http://www.logilab.fr/formations Développement logiciel sur mesure: http://www.logilab.fr/services CubicWeb, the semantic web framework: http://www.cubicweb.org

1 0

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

code-quality August 2013