code-quality July 2015

code-quality@python.org

14 participants
9 discussions

Adding python function arguments related customized rule in pylint

by Ahirnish Pareek

Hi all, I want to add a customized check to my pylintrc file to check and report cases whenever I define a function in a python file like this: def foo( var1, name1=value, *args ): The problem that I want to deal with is that we should not have keyword arguments( *name1* ) before positional arguments( **args* ). Although the function can still be called by passing *name1* as positional argument but there would be no way to not specify *name1* but specify **args*. How can I add this check to pylintrc file? Thanks in advance! -- Regards, Ahirnish

6 years, 1 month

Is there a way to speedup pylint by caching results between runs?

by Noam Yorav-Raphael

Hi, We're using pylint as a pre-commit hook to check our code. However, it takes about a minute for each run, and it's quite frustrating. I guess that most of the work is redundant, as most files do not change between runs. How hard would it be to add the ability to cache results to speed-up linting? I may be able to spend a day or two working on this, if there's a relatively simple way to do this. Is it possible? Thanks, Noam

6 years, 2 months

flake8 documentation out of date

by Mike Driscoll

Hi, I noticed that the documentation for flake8 on Read The Docs doesn't appear to be up-to-date: http://flake8.readthedocs.org/en/latest/config.html This page doesn't mention where to put the config file on Windows whereas the file that page is based on does (on Gitlab anyway): https://gitlab.com/pycqa/flake8/blob/master/docs/config.rst ----------------- Mike Driscoll Blog: http://blog.pythonlibrary.org Book: https://gumroad.com/l/bppWr

6 years, 2 months

Not Seeing PEP8 Formatting Errors

by Rich Shepard

I've numbered the lines in this code fragment: 83 category = Column(Unicode(16), value = 'Environmental', nullable = False, 84 CheckConstraint( 84 "category IN('Air', 'Environmental', 'Health', 'Safety', 'Occupancy', 86 'Water'")) flake8 has these errors: 84:39: E201 whitespace after '(' 86:9: E128 continuation line under-indented for visual indent I've read PEP8 and found several fora threads related to E128 and E201 but no matter how I reformat that statement I cannot remove these (or other) errors when flake8 runs on this module. When I continue line 84 the '(' and emacs breaks it near column 78 I get a different error about closing brackets not being correctly aligned. But, no matter where I place the final bracket it shows an error. This module has many error conditions simular to the above and I want to understand how these long lines should be formatted so flake8 no longer complains regardless of how I change the lines. Thanks in advance, Rich

6 years, 2 months

Questions: Flake8-2.4.1

by Rich Shepard

Just installed flake8-2.4.1. Checking a file generates this error: pwschemasl.py:698:39: E225 missing whitespace around operator on this line: rpt_filename=Column(BLOB, nullable=False) where position 39 is 'F'. So, I add the space: rpt_filename=Column(BLOB, nullable= False) and now flake8 shows this error: pwschemasl.py:698:40: E251 unexpected spaces around keyword / parameter equals This is an infinite loop that affects many lines of code in the file. The lines throw a PEP8 compliance error both with and without a space following the '=' sign. Is there something I've done incorrectly that I don't see? Puzzled, Rich

6 years, 2 months

.pylint.d has 170MB, how to clean?

by Štefan Hocko

Hello everybody, I found out that my .pylint.d directory has grown to 170MB, as I am working on a 1GB workspace this is a lot. I haven't found a way to clean it in the FAQ or manual. Can I just delete the contents without damaging PyLint? Thanks for answers, Best Regards, Stefan

6 years, 2 months

Detecting circular package dependencies with pylint (or similar tool)

by JuanLeon Lahoz

Hi, Is there any way to make pylint report circular package dependencies with an exit code != 0? Assume code has packages A and B. A.a1 imports B.b1, and B.b2 imports A.a2. While this may work, imho this is a bad smell in design that I want to detect as early as possible (same as any other bad smells that pylint detects). I know that pylint can write import dependency graphs, but I could not find a trivial way to use them a a check (trivial == no coding required). Any option that I am missing? Thanks juanleon

6 years, 3 months

PEP8's repository has moved to the PyCQA organization on GitHub

by Ian Cordasco

Hey everyone, I just wanted to let all of you know that late last night Johann Rocholl, creator of pep8, has moved the project to the PyCQA organization on GitHub. The new URL for the project is https://github.com/PyCQA/pep8. All old issues and pull requests are preserved as part of the process. For more information, please read http://www.coglib.com/~icordasc/blog/2015/07/moving-pep8-to-the-pycqa.html Cheers, Ian Cordasco Core developer of Flake8, requests, and a few other projects

6 years, 3 months

Searching multiple setup.cfg files for flake8 section?

by Willy Wu

Hey all, We use flake8 at Dropbox and are pretty happy with it. But one small issue is the way that flake8 configuration gets discovered. We use the per-project configuration via setup.cfg files which are checked into source control, but flake8 only considers the first setup.cfg in the directory path (regardless of whether it contains a flake8 section or not). This forces us to duplicate our [flake8] configuration across all of our various setup.cfgs. Said in crude ascii form, this is a simplified version of our project layout: - repo root |- setup.cfg (default values) \- subservice #1 \- setup.cfg (which has non-flake8 overrides for subservice #1) \- subservice #2 \- setup.cfg (which similarly contains non-flake8 overrides for subservice #2) But before I go off trying to patch flake8 code, is there relevant background on why you guys don't try to discover the first setup.cfg with a flake8 section, but instead just consider the first encountered setup.cfg? We've seen teams accidentally break flake8 checking whenever they add setup.cfg files for non-flake8 projects, and the "fix" is to copy/paste the flake8 section into those new files. Or alternatively, should we be doing something different with our project layout as a workaround? It's entirely possible that we should be configuring things differently overall...? Thanks! Willy

6 years, 3 months

2021

2020

2019

2018

2017

2016

2015

2014

2013

code-quality July 2015