code-quality April 2017

code-quality@python.org

14 participants
10 discussions

by Edward K. Ream

I just wanted to thank the pyflakes devs for having written the most useful checker in the python world. Pyflakes catches roughly 90% of the programming blunders I make, before ever I run the code. My configuration of Leo ensures that: - pyflakes checks all changed .py files as Leo writes them, - Leo raises a dialog so that I can't ignore pyflakes warnings :-) In other words, the pyflakes warnings are so important that it's worthwhile to stop everything and deal with them. 11 months ago I studied pyflakes in detail in this repo <https://github.com/edreamleo/pyflakes-study>. The introductory remarks called pyflakes a work of genius. My admiration for pyflakes has only grown since then. At that time I suggested some changes that would make pyflakes about 10% faster at the cost of making the code more complex. I regret making those suggestions. Pyflakes is plenty fast, even on Leo's biggest source files, some of which are almost 300K in size. Again, thank you for a truly great tool. Edward ------------------------------------------------------------------------------------------ Edward K. Ream: edreamleo(a)gmail.com Leo: http://leoeditor.com/ ------------------------------------------------------------------------------------------

4 years, 8 months

Flake8 and Python 3

by diek

Good Day, I have searched and read some posts on reddit and stack but I cannot get flake8 to use Python3. I looked at your docs, but I cannot find it. I am using a Python3 virtualenv, and I pip installed Flake8. Flake8 is installed: _env/lib/python3.6/site-packages/flake8/utils.py Running version: 3.3.0 (mccabe: 0.6.1, pycodestyle: 2.3.1, pyflakes: 1.5.0) CPython 2.7.13 on Darwin It is showing errors for items that are valid syntax. I require both Python 2 and 3 on my computer. I am sure I am not the first person to have this issue, please how do I resolve this? Thank you, derrick

4 years, 8 months

Pydocstyle 2.0.0 released

by Amir Rachum

Hi friends, Pydocstyle 2.0.0 was released and the new major version includes numpy convention support! You can find the full release notes here: http://www.pydocstyle.org/en/latest/release_notes.html#april-18th-2017 If you find any issues with this (or any other) version, please report them at our GitHub repo at: https://github.com/PyCQA/pydocstyle Cheers! Amir Rachum

4 years, 8 months

New Static Analysis Security Tool

by Kevin Hock

Hi, I just wanted to send you a link to a Python security project you or coworkers might be interested in https://github.com/python-security/pyt

4 years, 8 months

Why does pylint flag this?

by Mark Syms

We've recently started to see pylint flag issues on a piece of code that looks similar to this - --------------------------------------- #!/bin/python """ Test the TemporaryFile iterator """ import os import tempfile with tempfile.TemporaryFile() as nullfh: nullfh.write(b'Hello world!') nullfh.seek(0, os.SEEK_SET) for line in nullfh: line = line.strip() print line --------------------------------------- With pylint 1.7.1, astroid 1.5.2 Python 2.7.5 (default, Nov 6 2016, 00:28:07) This reports - E: 13,16: Non-iterable value nullfh is used in an iterating context (not-an-iterable) However the code is functional so nullfh does work in the iterating context. Any clues as to why this is being flagged would be appreciated. Thanks, Mark.

4 years, 9 months

Proposal to extend pylintrc syntax to allow multiple disable/enable parameters

by Michael Overmeyer

Hello, I'm trying to set up my build system to use pylintrc files during the build. For example, in my pylintrc file I was going to do something like: ``` disable=all enable=E disable=import-error ``` Which (of course) doesn't work: ``` $>pylint --rcfile=pylintrc my_file.py <stacktrace truncated> backports.configparser.DuplicateOptionError: While reading from 'pylintrc' [line 24]: option u'disable' in section u'MESSAGES CONTROL' already exists ``` Once I realised that they are INI files, it made more sense. INI files do not allow for multiple values for a key (within a section), and different parsers handle this case differently. Since strict=True was being used by the Python parser, it raise this exception. The annoying part is that you can pass multiple 'enable/disable' arguments on the command line. In fact, there is an example in the documentation auto-generated by `pylint --generate-rcfile`: "If you want to run only the classes checker, but have no Warning level messages displayed, use '--disable=all --enable=classes --disable=W'" But this cannot be done in the pylintrc file. Annoying, since I was not going to use the command line and changing my build system to do would be non-trivial. I would like to see the pylintrc file have at least as much capability as the command line. I would like to propose to extend the syntax to provide an ordering. Proposal: Today we have "disable" and "enable", with "enable" taking precedent. Perhaps we could change the syntax to be "disableX" "enableY", with X and Y being positive integers. Higher precedence would be determined by higher integers. "enable" would still have precedent within a given integer level. It would be backwards compatible, with 'disable' being an alias for 'disable1' and 'enable' being an alias for 'enable1'. Some examples: ``` disable=all enable=classes disable2=W ``` would be equivalent to: ``` disable1=all enable1=classes disable2=W ``` There could easily be a better way to do that this, or some pattern/syntax people already use when dealing with INI files in order to work around this. I would like to see the pylintrc file have at least as much capability as the command line. Let me know what you think, Michael Overmeyer

4 years, 9 months

Bug Report: pylint on Windows has problems dealing with Python directory with spaces

by 张胜利

Hi pylint team: Bug Report: pylint on Windows has problems dealing with Python directory with spaces.

4 years, 9 months

Pylint 1.7.0 was released

by Claudiu Popa

Hey folks, We just released a new version of Pylint, 1.7.0, after a long period of time since the last release. You can find more details about what's new in this release over here: https://pylint.readthedocs.io/en/latest/whatsnew/1.7.html Thanks and enjoy, Claudiu

4 years, 9 months

W0602 global-variable-not-assigned

by Josh Powers

Hi, I have code similar to [1] where instead of directly assigning a dictionary global variable the dictionary method update is used. Right now this results in a W0602 global-variable-not-assigned. Is this expected behavior and if so is there a better way to write the above? The actual code giving me this message is in cloud-init [2]. [1] https://paste.ubuntu.com/24330114/ [2] https://github.com/cloud-init/cloud-init/blob/master/cloudinit/util.py#L114 --- Josh Powers Ubuntu Server Canonical Ltd

4 years, 9 months

Pylint -- so which is it?

by Stephen Satchell

I have a python2.7 project, and when I run PyLint 1.5.2, astroid 1.3.3 on files, I get a Catch-22 situation. When I have: import logging import pexpct import re import time I get messages about wrong import order, specifically that re and time comes after pexpect. OK, apply the obvious fix: import logging import re import time import pexect and now the diagnostics I get are "standard import "re" comes before "pexpect". ditto "time". Can't win for losing. So how do I fix this, other than abandoning programming and take up advanced backet-weaving as a profession? :) (Yes, I did check back six months in the mailing list archives, and didn't see any discussion.)

4 years, 9 months

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

code-quality April 2017