Mailman 3 January 2018 - code-quality

Pylint hosting on ReadTheDocs prevents successful searches
by Quantum Mechanic 02 Feb '18

02 Feb '18

Googling for "pylint pylintrc" gives me the first hit as https://docs.pylint.org/en/1.6.0/run.html. This lands me on https://docs.pylint.org/en/1.6.0/run.html, asking me to login. I have a login, and clicking "Login" sends me to https://readthedocs.org/dashboard/, spoiling the google search. In fact, searching on google only shows me that something might be there. I have to search *again* on ReadTheDocs, which isn't friendly at all. Poking around until I find a search box at https://pylint.readthedocs.io/en/latest/, I type in "pylintrc", which returns the *same bloody page* (OK, yes, it has this helpful bit: https://pylint.readthedocs.io/en/latest/?highlight=pylintrc, which does exactly...nothing.) So I'm stuck trolling around in the full docs there. Instead, I should just pull down the source code, and do my own grep -r. I feel like I've been violated. -- -QM Quantum Mechanics: The dreams stuff is made of

6 10

pylint import succeeds or fails depending on a previous import statement
by Alexey Bashtanov 24 Jan '18

24 Jan '18

Hello, I came across the following problem with pylint: a import from a local directory works only if there's some `from ... import ...` statement above. My code is organized as follows: ~/pylinttest/ foo/ bar.py baz.py qux.py __init__.py .pylintrc bar.py contains the following code: from urllib import request import qux baz.py contains the following code: import qux Here are the results of running pylint: alexey@ev9d9:~/pylinttest$ pylint foo.bar Using config file /home/alexey/pylinttest/.pylintrc ************* Module foo.bar W: 1, 0: Unused request imported from urllib (unused-import) W: 2, 0: Unused import qux (unused-import) alexey@ev9d9:~/pylinttest$ pylint foo.baz Using config file /home/alexey/pylinttest/.pylintrc ************* Module foo.baz E: 1, 0: Unable to import 'qux' (import-error) W: 1, 0: Unused import qux (unused-import) Why does it fail to load qux only if there was no from-import statement before? Changing urllib.request to e.g. collections.deque does not make a difference. My pylint version is 1.1.0, and it can be reproduced both with python 2.7.5 and 3.4.0 Regards, Alexey

1 1

pylint-django move to PyQCA?
by Carl Crowder 23 Jan '18

23 Jan '18

Hi all, I’ll be quick - I think pylint-django is better under PyCQA! If you agree I will help out wherever necessary I built it out of a hope I could help bring pylint to Django users so I hope that has helped, people seem to use it so I hope moving it to PyCQA helps users of it too! Carl

2 1

SnekChek - Python Linter wrapper
by Martmists 20 Jan '18

20 Jan '18

Hello members of PyCQA, I am martmists, current owner of the IzunaDevs organization, and I'm currently working on a library called SnekChek (which you can find here <https://github.com/izunadevs/snekchek>) I was wondering if you were interested in taking over this package to your repository with me as main contributor, as I will keep updating this package as time goes by (unlike coala or ciocheck) while also supporting as many linters/checkers as possible. I'm also interested in what kind of input you guys have for me, as this is the first time I'm writing a wrapper for these things and I'm not sure if I'm doing it the correct way. I look forward to hearing your response. ~ Martmists

2 1

Need help with debugging pylint tests for a plugin
by Alexander Todorov 16 Jan '18

16 Jan '18

Hi folks, I've made several commits to django-pylint (https://github.com/MrSenko/django-pylint, branch next_release) in order to make it compatible with the latest available versions. However some of the existing tests fail and I'm not sure how to figure out what's wrong: https://travis-ci.org/MrSenko/django-pylint/jobs/329526377 For example the failure about file "func_noerror_ignore_meta_subclass.py" reports: Unexpected in testdata: 11: too-few-public-methods At the same time if I execute pylint + my plugin from the command line I don't get any errors reported: $ PYTHONPATH=. pylint --load-plugins pylint_django test/input/func_noerror_ignore_meta_subclass.py No config file found, using default configuration -------------------------------------------------------------------- Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00) Without going into much details about the code of pylint_django there's a function which is supposed to suppress this message if it is triggered by a class Meta: definition (standard thing for Django). When running manually from the command line this error message is suppressed. When running from tests (via pytest) the suppression doesn't seem to work. Any ideas on how to debug further ? Thanks, Alex

1 0

A couple pylint feature requests
by Skip Montanaro 10 Jan '18

10 Jan '18

As I work through code, especially while refactoring, I wish pylint was at times more stringent about lack of use of certain types of objects. At the moment, I'm thinking of two scenarios, main programs and private attributes. There's a clear difference between a program and a module, the main one being that a module "exports" its module-level symbols, while a main program doesn't (at least if it isn't intended to also serve as a module). It would be nice if there was a pylint checker which indicated for main programs module-level symbols which aren't used somewhere within that file. It might be off by default, but be enabled if you passed a --main flag on the command line, or if the the usual "if __name__" dance was found at the bottom of the file. In a similar fashion, I think it would be useful if private attributes (typically functions or methods, but also data attributes) were called out in any environment where they were defined but not used. It's considered bad practice to reach into an object and reference private attributes. Conversely, if a private attribute isn't "exported," it should almost certainly be used with that namespace. Skip

1 0