Mailman 3 September 2019 - code-quality

On the topic of Codes of Conduct
by Ian Stapleton Cordasco 05 Oct '19

05 Oct '19

Hi everyone, A few days ago, there was a thread where a member brought up the code of conduct to another member. In particular, as this list is provided by the Python Software Foundation, we are observing the PSF Code of Conduct. We are all expected to observe the code of conduct and I would expect that people would feel safe raising violations of the code of conduct. Furthermore, people shouldn't feel as if being asked to observe the Code of Conduct is a threat or a violation of the Code of Conduct. The Code of Conduct exists to ensure that everyone feels safe participating in this community. Granted, it's not a particularly active community but it should be capable of representing the global Python community. If having to observe the Code of Conduct offends you or makes you feel personally unsafe, perhaps you need to think long and hard about why that is. If you think that you can't abide by the Code of Conduct, you are not required to continue to subscribe to this list or participate in its discussions. To be clear, I have no intention to litigate the interaction from a few days ago. No complaint seems to have been made. Further, there's no intent to entertain discussion of moving this list off of PSF infrastructure to bypass a Code of Conduct as any list with me as a moderator or administrator will require a CoC. Cheers, Ian

2 1

[Pylint] Linting Module setting
by CrestChristopher 29 Sep '19

29 Sep '19

I want to know the correct setting within Pylint if one wants to include a module to be linted; I’m hoping it is this setting ? # List of plugins (as comma separated values of python modules names) to load, # usually to register additional checkers. load-plugins= Thank You Christopher

1 0

Problem with del and pylint
by Stephen Satchell 21 Sep '19

21 Sep '19

This is a minor thing, but it is puzzling. Here is a code fragment from a project I'm working on: > for device_id in job.devices: > device = job.devices[device_id] > <loop> > del device_id > del device When I run pylint (version 1.6.5, astroid 1.4.9) against this code, I get one warning diagnostic: > Using possibly undefined loop variable 'device_id' (undefined-loop-variable) Experimenting with Python 2, the loop variable is indeed in the name space of the function I'm running. I get the same result with Python 3, the loop variable is indeed in the function namespace. The reason I'm using 'del' is to avoid name collisions on other sections of code being written at different times -- this project has gone two months already. My "workaround" is to remove the del statement for the loop variable, and leaving the rest of the del statements in for variables inside the loop that (being a ex PL/1 programmer) I would assume would be out of scope, but aren't. I may move this loop into a separate function, and remove the need for the del statements. Comments?

3 4

Problem with del and pylint
by Stephen Satchell 20 Sep '19

20 Sep '19

This is a minor thing, but it is puzzling. Here is a code fragment from a project I'm working on: > for device_id in job.devices: > device = job.devices[device_id] > <loop> > del device_id > del device When I run pylint (version 1.6.5, astroid 1.4.9) against this code, I get one warning diagnostic: > Using possibly undefined loop variable 'device_id' (undefined-loop-variable) Experimenting with Python 2, the loop variable is indeed in the name space of the function I'm running. I get the same result with Python 3, the loop variable is indeed in the function namespace. The reason I'm using 'del' is to avoid name collisions on other sections of code being written at different times -- this project has gone two months already. My "workaround" is to remove the del statement for the loop variable, and leaving the rest of the del statements in for variables inside the loop that (being a ex PL/1 programmer) I would assume would be out of scope, but aren't. I may move this loop into a separate function, and remove the need for the del statements. Comments?

1 0

Looking for Python tool to calculate string similarity
by Alexander Todorov 16 Sep '19

16 Sep '19

Hi folks, I am looking for some tool (or algorithm which I can implement at the worst) which calculates similarities between strings. I would turn this into a pylint plugin b/c this is how I would consume it in my projects. My background is that we've identified *duplicate* or *similar* strings in our project which are marked for translation. Some of these are upper case vs. lower case and all of the variations between (I can lower case everything before sending to the tool of course), variances in spelling, e.g. "test case" vs "TestCase", variations into how certain words/combination of words are used together in a sentence, e.g. "user does not exist" vs. "the user specified was not found". Ideally I'd like to consume this tool in CI and based on the results reduce the number of source strings needed for translation and make life for translators easier. Feel free to propose anything, I have not done any research on this topic. Thanks, Alex

10 13