Using a linter on introduced code
Hello, I am working on a tool that integrates pylint with github pull requests[1]. My goal is to make the linting process as less disruptive as possible and help devs fix issues in their code before submitting it to review. I saw in another thread that some of you already have some experience using a linter on introduced code. Before continuing working on my approach I am curious to see how other approaches worked and how others introduced this in their team's workflow. Thanks, Mihai [1] https://github.com/mihaibivol/pylinthub
On 3/28/14 10:30 AM, Mihai Bivol wrote:
Hello,
I am working on a tool that integrates pylint with github pull requests[1]. My goal is to make the linting process as less disruptive as possible and help devs fix issues in their code before submitting it to review. I saw in another thread that some of you already have some experience using a linter on introduced code. Before continuing working on my approach I am curious to see how other approaches worked and how others introduced this in their team's workflow.
We have a tool that does coverage and pylint measurement on github submissions: http://engineering.edx.org/2013/12/diff-cover-test-coverage-for-git-commits/ It's run automatically by our Jenkins CI server, and many developers run it locally to check on the work they are about to submit. --Ned.
Thanks, Mihai
[1] https://github.com/mihaibivol/pylinthub _______________________________________________ code-quality mailing list code-quality@python.org https://mail.python.org/mailman/listinfo/code-quality
----- Original Message -----
From: "Ned Batchelder" <ned@nedbatchelder.com> To: code-quality@python.org Sent: Friday, March 28, 2014 11:05:06 AM Subject: Re: [code-quality] Using a linter on introduced code
On 3/28/14 10:30 AM, Mihai Bivol wrote:
Hello,
I am working on a tool that integrates pylint with github pull requests[1]. My goal is to make the linting process as less disruptive as possible and help devs fix issues in their code before submitting it to review. I saw in another thread that some of you already have some experience using a linter on introduced code. Before continuing working on my approach I am curious to see how other approaches worked and how others introduced this in their team's workflow.
We have a tool that does coverage and pylint measurement on github submissions: http://engineering.edx.org/2013/12/diff-cover-test-coverage-for-git-commits/ It's run automatically by our Jenkins CI server, and many developers run it locally to check on the work they are about to submit.
--Ned.
Thanks, Mihai
[1] https://github.com/mihaibivol/pylinthub _______________________________________________ code-quality mailing list code-quality@python.org https://mail.python.org/mailman/listinfo/code-quality
_______________________________________________ code-quality mailing list code-quality@python.org https://mail.python.org/mailman/listinfo/code-quality
It was not hard to write a little script to make use of code-quality for my somewhat different scenario, i.e., developer has a bunch of commits stacked up and they're interested in running code-quality on the changes that comprise those commits before submitting for review. The dead simple script here: https://github.com/dwlehman/blivet/blob/master/scripts/pylintcodediff is kind of reckless with your working branch, but I expect to be pushing a few patches for that in the very near future to make it a bit safer. So far it is not a git-hook or anything like that, it needs a bit of work before I'ld be willing to automate it. - mulhern
participants (3)
-
Anne Mulhern -
Mihai Bivol -
Ned Batchelder