Hello all, The pyflakes-study code <https://github.com/edreamleo/pyflakes-study> project is complete. I am wondering whether a pull request for the actual pyflakes project would be appropriate. I would be happy to issue the pull request, but I'm not sure how to do that from one project (pyflakes_study) to another (pyflakes itself). Perhaps the pyflakes devs could investigate what I have done first. Notes: 1. Only checker.py should have to change. All other files would remain unchanged. 2. All unit tests pass within the pyflakes-study environment, with the exception of the api tests, which rely on the actual pyflakes directory structure. 3. The new code uses two top-level switches, aft (use the AstFullTraverser class) and new_scope (replace the scope property with a few other lines of code). Leaving in these switches makes it easy to see where the substantive changes are, but presumably they would be removed from the final code after your evaluation. 4. I changed _FieldsOrder._get_fields during my study, but this method disappears when aft is True. Several other important methods also disappear when aft is True. 5. It would be possible to evaluate checker.py using any editor, but the best view of the code is obtained by using Leo, that is, pyflakes_study.leo. Otoh, I am not suggesting that this .leo file be part of the official pyflakes distro. All comments and suggestions welcome. Edward ------------------------------------------------------------------------------------------ Edward K. Ream: edreamleo@gmail.com Leo: http://leoeditor.com/ ------------------------------------------------------------------------------------------
On 06/08/2016 08:31 AM, Edward K. Ream wrote:
The pyflakes-study code <https://github.com/edreamleo/pyflakes-study> project is complete. I am wondering whether a pull request for the actual pyflakes project would be appropriate.
I would be happy to issue the pull request, but I'm not sure how to do that from one project (pyflakes_study) to another (pyflakes itself). Perhaps the pyflakes devs could investigate what I have done first.
Consider the pull requested. I'm slammed with personal commitments right now, but I'll be sure to take a look in a couple weeks after things have settled down. From what I've read from your changes they sound really great. Thank you for taking the time to do this, and I promise your work won't go unnoticed.
participants (2)
-
Edward K. Ream
-
Phil Frost