Mailman 3 Static checker for common Python programming errors - code-quality

Static checker for common Python programming errors

older
RedBaron, a bottom-up refactoring...

Stefan Bucur

17 Nov 2014 17 Nov '14

5:18 p.m.

I'm developing a Python static analysis tool that flags common programming errors in Python programs. The tool is meant to complement other tools like Pylint (which perform checks at lexical and AST level) by going deeper with the code analysis and keeping track of the possible control flow paths in the program (path-sensitive analysis). For instance, a path-sensitive analysis detects that the following snippet of code would raise an AttributeError exception: if object is None: # If the True branch is taken, we know the object is None object.doSomething() # ... so this statement would always fail I wanted first to tap into people's experience and get a sense of what common pitfalls in the language & its standard library such a static checker should look for. Just as an example of what I mean, here [1] is a list of static checks for the C++ language, as part of the Clang static analyzer project. My preliminary list of Python checks is quite rudimentary, but maybe could serve as a discussion starter: * Proper Unicode handling (for 2.x) - encode() is not called on str object - decode() is not called on unicode object * Check for integer division by zero * Check for None object dereferences Thanks a lot, Stefan Bucur [1] http://clang-analyzer.llvm.org/available_checks.html

Attachments:

attachment.htm (text/html — 1.6 KB)

Show replies by date

Ben Finney

18 Nov 18 Nov

5:20 a.m.

New subject: Static checker for common Python programming errors

Stefan Bucur writes:

...

For instance, a path-sensitive analysis detects that the following snippet of code would raise an AttributeError exception:

if object is None: # If the True branch is taken, we know the object is None object.doSomething() # ... so this statement would always fail

Be careful with this. The above example would behave as you say; but it is a special case because re-binding ‘None’ is a SyntaxError. For most other built-ins, and for most other names, the above type of check cannot be done with static analysis.

...

I wanted first to tap into people's experience and get a sense of what common pitfalls in the language & its standard library such a static checker should look for.

Prior art to investigate includes PyLint and PyFlakes. You probably already know, but it bears saying explicitly.

...

My preliminary list of Python checks is quite rudimentary […]

Obvious ones: * Mutable-value argument defaults (should instead use the ‘None’ or a custom sentinel). I think you can only detect this when the default is specified as some literal value of a built-in type. * Comparing to None by equality (should be comparing by identity). * A single value in parens (author might mistakenly believe it's a tuple). Heck, any of the Idiomatic Python warnings that you can detect URL:http://python.net/~goodger/projects/pycon/2007/idiomatic/. -- \ “[The RIAA] have the patience to keep stomping. They're playing | `\ whack-a-mole with an infinite supply of tokens.” —kennon, | _o__) http://kuro5hin.org/ | Ben Finney

Claudiu Popa

12:25 p.m.

New subject: Static checker for common Python programming errors

On Mon, Nov 17, 2014 at 7:18 PM, Stefan Bucur wrote:

...

I'm developing a Python static analysis tool that flags common programming errors in Python programs. The tool is meant to complement other tools like Pylint (which perform checks at lexical and AST level) by going deeper with the code analysis and keeping track of the possible control flow paths in the program (path-sensitive analysis).

Hey, Stefan. That's great! It's really cool to see more people interested in static analysis with Python. Control flow analysis is missing in Pylint and due to this, we have a couple of false positives. For instance, the following code will emit a raising-bad-type warning, even though exc is later reassigned (but not deduced by the inference engine): exc = None for i in range(10): try: 1 / 0 break except Exception as e: exc = e else: raise exc I was planning to tackle this issue, by adding a rudimentary flow statement analysis to Pylint's inference engine, but oriented on high level paths.

Stefan Bucur

25 Nov 25 Nov

10:50 a.m.

New subject: Static checker for common Python programming errors

On Tue Nov 18 2014 at 1:25:07 PM Claudiu Popa wrote:

...

...
I'm developing a Python static analysis tool that flags common

...
errors in Python programs. The tool is meant to complement other tools

On Mon, Nov 17, 2014 at 7:18 PM, Stefan Bucur wrote: programming like

...
Pylint (which perform checks at lexical and AST level) by going deeper with the code analysis and keeping track of the possible control flow paths in the program (path-sensitive analysis).

Hey, Stefan.

That's great! It's really cool to see more people interested in static analysis with Python. Control flow analysis is missing in Pylint and due to this, we have a couple of false positives. For instance, the following code will emit a raising-bad-type warning, even though exc is later reassigned (but not deduced by the inference engine):

exc = None for i in range(10): try: 1 / 0 break except Exception as e: exc = e else: raise exc

This is very interesting (and a good reminder of the existence of the for/else construct, which I should probably use more often :) ). It would actually be nice to have a suite of such snippets, to be able to benchmark analysis tools more uniformly. Stefan

Steven D'Aprano

18 Nov 18 Nov

12:31 p.m.

New subject: Static checker for common Python programming errors

On Mon, Nov 17, 2014 at 05:18:03PM +0000, Stefan Bucur wrote:

...

I wanted first to tap into people's experience and get a sense of what common pitfalls in the language & its standard library such a static checker should look for. [...] * Proper Unicode handling (for 2.x) - encode() is not called on str object - decode() is not called on unicode object * Check for integer division by zero * Check for None object dereferences

This is a very interesting question, and quite hard to answer too. I presume that there will be a way to disable the check for individual lines of code, because these are not always wrong. * Check for `is` comparisons against arbitrary objects, especially int and str literals. * Equality comparisons against None (should use `is`). * Calling str.find() and str.rfind() without checking for a return result of -1. * Calling re.match() and similar without checking for a result of None. * alist = alist.sort() and similar. * Calling print for its return value, e.g.: print("template %s") % obj * Mutable default values in functions and methods. * Modifying a sequence or iterator while iterating over it, e.g. for i, x in enumerate(alist): if condition(x): del alist[i] I've done all of these :-( -- Steven

Dave Halter

1:01 p.m.

New subject: Static checker for common Python programming errors

Hi Stefan I'm playing with this as well in Jedi. I'm pretty far with flow analysis and AttributeErrors. (This includes everything you mention above except integer division by zero). Would be easy to implement in Jedi, though. I just have different priorities, at the moment. If you have some time on your hands you can watch my EuroPython talk about this: https://www.youtube.com/watch?v=DfVHSw0iOsk I'm also glad to skype (gaukler_) if you're interested. Jedi is not well known for doing static analysis. But it's my goal to change this now. ~ Dave 2014-11-17 18:18 GMT+01:00 Stefan Bucur :

...

I'm developing a Python static analysis tool that flags common programming errors in Python programs. The tool is meant to complement other tools like Pylint (which perform checks at lexical and AST level) by going deeper with the code analysis and keeping track of the possible control flow paths in the program (path-sensitive analysis).

For instance, a path-sensitive analysis detects that the following snippet of code would raise an AttributeError exception:

if object is None: # If the True branch is taken, we know the object is None object.doSomething() # ... so this statement would always fail

I wanted first to tap into people's experience and get a sense of what common pitfalls in the language & its standard library such a static checker should look for. Just as an example of what I mean, here [1] is a list of static checks for the C++ language, as part of the Clang static analyzer project.

My preliminary list of Python checks is quite rudimentary, but maybe could serve as a discussion starter:

* Proper Unicode handling (for 2.x) - encode() is not called on str object - decode() is not called on unicode object * Check for integer division by zero * Check for None object dereferences

Thanks a lot, Stefan Bucur

[1] http://clang-analyzer.llvm.org/available_checks.html

_______________________________________________ code-quality mailing list code-quality@python.org https://mail.python.org/mailman/listinfo/code-quality

Stefan Bucur

25 Nov 25 Nov

11:29 a.m.

New subject: Static checker for common Python programming errors

On Tue Nov 18 2014 at 2:01:46 PM Dave Halter wrote:

...

Hi Stefan

I'm playing with this as well in Jedi. I'm pretty far with flow analysis and AttributeErrors. (This includes everything you mention above except integer division by zero). Would be easy to implement in Jedi, though. I just have different priorities, at the moment.

If you have some time on your hands you can watch my EuroPython talk about this: https://www.youtube.com/watch?v=DfVHSw0iOsk I'm also glad to skype (gaukler_) if you're interested. Jedi is not well known for doing static analysis. But it's my goal to change this now.

Thanks Dave for the pointer. I watched your talk and had a look at Jedi's code — this is quite nice and would indeed be great to better expose the static analysis potential of the framework. What I'm trying to achieve is something a bit different. My goal is to reuse as much as possible the "implicit specs" of the interpreter itself (CPython), as opposed to implementing them again in my analysis tool. We already have an execution engine that uses the interpreter to automatically explore multiple paths through a piece of Python code. You can read here the academic paper, with case studies for Python and Lua: http://dslab.epfl.ch/pubs/chef.pdf I'm now working on extending this technique to other types of analyses and I'm trying to determine the most relevant types of analyses and checks for Python. So far, I conclude that type inference would serve multiple purposes and is on the top of my list. Stefan

...

2014-11-17 18:18 GMT+01:00 Stefan Bucur :

...
I'm developing a Python static analysis tool that flags common programming errors in Python programs. The tool is meant to complement other tools like Pylint (which perform checks at lexical and AST level) by going deeper with the code analysis and keeping track of the possible control flow paths in the program (path-sensitive analysis).

For instance, a path-sensitive analysis detects that the following snippet of code would raise an AttributeError exception:

if object is None: # If the True branch is taken, we know the object is None object.doSomething() # ... so this statement would always fail

I wanted first to tap into people's experience and get a sense of what common pitfalls in the language & its standard library such a static checker should look for. Just as an example of what I mean, here [1] is a list of static checks for the C++ language, as part of the Clang static analyzer project.

My preliminary list of Python checks is quite rudimentary, but maybe could serve as a discussion starter:

* Proper Unicode handling (for 2.x) - encode() is not called on str object - decode() is not called on unicode object * Check for integer division by zero * Check for None object dereferences

Thanks a lot, Stefan Bucur

[1] http://clang-analyzer.llvm.org/available_checks.html

_______________________________________________ code-quality mailing list code-quality@python.org https://mail.python.org/mailman/listinfo/code-quality

Dave Halter

1:27 p.m.

New subject: Static checker for common Python programming errors

2014-11-25 12:29 GMT+01:00 Stefan Bucur :

...

On Tue Nov 18 2014 at 2:01:46 PM Dave Halter wrote:

...
Hi Stefan

I'm playing with this as well in Jedi. I'm pretty far with flow analysis and AttributeErrors. (This includes everything you mention above except integer division by zero). Would be easy to implement in Jedi, though. I just have different priorities, at the moment.

If you have some time on your hands you can watch my EuroPython talk about this: https://www.youtube.com/watch?v=DfVHSw0iOsk I'm also glad to skype (gaukler_) if you're interested. Jedi is not well known for doing static analysis. But it's my goal to change this now.

Thanks Dave for the pointer. I watched your talk and had a look at Jedi's code — this is quite nice and would indeed be great to better expose the static analysis potential of the framework.

What I'm trying to achieve is something a bit different. My goal is to reuse as much as possible the "implicit specs" of the interpreter itself (CPython), as opposed to implementing them again in my analysis tool.

We already have an execution engine that uses the interpreter to automatically explore multiple paths through a piece of Python code. You can read here the academic paper, with case studies for Python and Lua: http://dslab.epfl.ch/pubs/chef.pdf

Stefan, I haven't read the full paper (but most of it). Interesting stuff! Are you doing any "argument propagation" or are you simply looking at a function without argument knowledge? How do you does your output look like? Can you give us a real world example (maybe simplejson)? Would be really interesting. BTW: I remember asking the same question that you asked here in the beginning: "What are your most typical mistakes that you would like a static analysis tool pick up?" https://github.com/davidhalter/jedi/issues/408 The first maybe 10 answers might interest you. ~ Dave

...

I'm now working on extending this technique to other types of analyses and I'm trying to determine the most relevant types of analyses and checks for Python. So far, I conclude that type inference would serve multiple purposes and is on the top of my list.

Stefan

...
2014-11-17 18:18 GMT+01:00 Stefan Bucur :

...
I'm developing a Python static analysis tool that flags common programming errors in Python programs. The tool is meant to complement other tools like Pylint (which perform checks at lexical and AST level) by going deeper with the code analysis and keeping track of the possible control flow paths in the program (path-sensitive analysis).

For instance, a path-sensitive analysis detects that the following snippet of code would raise an AttributeError exception:

if object is None: # If the True branch is taken, we know the object is None object.doSomething() # ... so this statement would always fail

I wanted first to tap into people's experience and get a sense of what common pitfalls in the language & its standard library such a static checker should look for. Just as an example of what I mean, here [1] is a list of static checks for the C++ language, as part of the Clang static analyzer project.

My preliminary list of Python checks is quite rudimentary, but maybe could serve as a discussion starter:

* Proper Unicode handling (for 2.x) - encode() is not called on str object - decode() is not called on unicode object * Check for integer division by zero * Check for None object dereferences

Thanks a lot, Stefan Bucur

[1] http://clang-analyzer.llvm.org/available_checks.html

_______________________________________________ code-quality mailing list code-quality@python.org https://mail.python.org/mailman/listinfo/code-quality

Stefan Bucur

2:20 p.m.

New subject: Static checker for common Python programming errors

On Tue Nov 25 2014 at 2:27:46 PM Dave Halter wrote:

...

2014-11-25 12:29 GMT+01:00 Stefan Bucur :

...
On Tue Nov 18 2014 at 2:01:46 PM Dave Halter wrote:

...
Hi Stefan

I'm playing with this as well in Jedi. I'm pretty far with flow analysis and AttributeErrors. (This includes everything you mention above except integer division by zero). Would be easy to implement in Jedi, though. I just have different priorities, at the moment.

If you have some time on your hands you can watch my EuroPython talk about this: https://www.youtube.com/watch?v=DfVHSw0iOsk I'm also glad to skype (gaukler_) if you're interested. Jedi is not well known for doing static analysis. But it's my goal to change this now.

Thanks Dave for the pointer. I watched your talk and had a look at Jedi's code — this is quite nice and would indeed be great to better expose the static analysis potential of the framework.

What I'm trying to achieve is something a bit different. My goal is to reuse as much as possible the "implicit specs" of the interpreter itself (CPython), as opposed to implementing them again in my analysis tool.

We already have an execution engine that uses the interpreter to automatically explore multiple paths through a piece of Python code. You can read here the academic paper, with case studies for Python and Lua: http://dslab.epfl.ch/pubs/chef.pdf

Stefan, I haven't read the full paper (but most of it). Interesting stuff! Are you doing any "argument propagation" or are you simply looking at a function without argument knowledge?

There is no explicit handling of the Python semantics in Chef (our tool)—this is the major advantage of the technique. The Python interpreter simply runs the code under test inside the symbolic x86 VM. An example may help clarify this (see below).

...

How do you does your output look like?

The output is a set of test cases that comprise an automatically-generated test suite for the program under test. These test cases capture all the execution paths (including corner cases & buggy cases) discovered automatically during execution.

...

Can you give us a real world example (maybe simplejson)? Would be really interesting.

Say we want to test the code in the simplejson package. Traditionally, one would write a suite of unit tests that exercise a predetermined set of input-output pairs. For instance, you'd have to think of what inputs would best cover the package behavior, i.e., valid JSON, invalid JSON, empty strings, slightly malformed JSON, and so on. This is quite tedious and one may very well miss obscure corner cases. However, with Chef, we write instead so called "symbolic tests", which use Chef's API. Here is a simple example for simplejson, say *simplejson_test.py:* import importlib import simplejson import sys *from chef import light* class SimpleJSONTest(*light.SymbolicTest*): def setUp(self): pass def runTest(self): simplejson.loads(*self.getString("input", '\x00'*15)*) if __name__ == "__main__": *light.runFromArgs(SimpleJSONTest, arg_list=sys.argv)* This piece of code does several things: * It encapsulates the test functionality in a test class that derives from light.SymbolicTest (as opposed to Python's own TestCase). * Instead of defining a particular JSON string to pass to simplejson, it asks the framework to construct one, according to some specs. In this case, it asks for a string that will be referred to as "input", of 15 characters, with a default value of null characters everywhere. * When the script is executed, the framework instantiates the symbolic test and runs it. You can run simplejson_test.py in two modes: 1) In symbolic mode, the test runs inside the symbolic virtual machine. The call to SimpleJSONTest.getString(...) returns a special "symbolic string", which taints the returned variable and causes the execution of the interpreter to "fork" (akin to a process fork) everytime a branch depending on the symbolic string is encountered during execution. This works everywhere inside the interpreter -- either for Python-level branches, or for native branches inside C extension modules -- because the symbolic VM runs at x86 level. Every time the execution forks, the framework generates a new "test case" -- a concrete assignment to the symbolic string that would cause the interpreter to execute precisely the newly discovered path (e.g., the '{ "key": 1}' string). 2) In replay mode, all the test cases generated in symbolic mode can be replayed via the same simplejson_test.py file. In this mode, the SimpleJSONTest.getString(...) call returns one of the concrete input assignments generated and checks that the replayed output matches the output observed in symbolic mode (this is to weed out nondeterminism).

...

BTW: I remember asking the same question that you asked here in the beginning: "What are your most typical mistakes that you would like a static analysis tool pick up?" https://github.com/davidhalter/jedi/issues/408 The first maybe 10 answers might interest you.

Oh, this is excellent! Thanks a lot! Cheers, Stefan

...

...
I'm now working on extending this technique to other types of analyses and I'm trying to determine the most relevant types of analyses and checks for Python. So far, I conclude that type inference would serve multiple purposes and is on the top of my list.

Stefan

...
2014-11-17 18:18 GMT+01:00 Stefan Bucur :

...
I'm developing a Python static analysis tool that flags common programming errors in Python programs. The tool is meant to complement other tools like Pylint (which perform checks at lexical and AST level) by going deeper with the code analysis and keeping track of the possible control flow paths in the program (path-sensitive analysis).

For instance, a path-sensitive analysis detects that the following snippet of code would raise an AttributeError exception:

if object is None: # If the True branch is taken, we know the object is None object.doSomething() # ... so this statement would always fail

I wanted first to tap into people's experience and get a sense of what common pitfalls in the language & its standard library such a static checker should look for. Just as an example of what I mean, here [1] is a list of static checks for the C++ language, as part of the Clang static analyzer project.

My preliminary list of Python checks is quite rudimentary, but maybe could serve as a discussion starter:

* Proper Unicode handling (for 2.x) - encode() is not called on str object - decode() is not called on unicode object * Check for integer division by zero * Check for None object dereferences

Thanks a lot, Stefan Bucur

[1] http://clang-analyzer.llvm.org/available_checks.html

_______________________________________________ code-quality mailing list code-quality@python.org https://mail.python.org/mailman/listinfo/code-quality

3433

Age (days ago)

3441

Last active (days ago)

List overview

Download

8 comments

5 participants

participants (5)

Ben Finney
Claudiu Popa
Dave Halter
Stefan Bucur
Steven D'Aprano

Static checker for common Python programming errors

tags

participants (5)