Mailman 3 used-before-assignment warning with := - code-quality - python.org

newer
Pyside2, QAbstractItemModel...

used-before-assignment warning with :=

older
PyFlakes and function calls

Ed Lipson

30 May 2021 30 May '21

7:36 p.m.

I was running pylint (2.6.0) in VS Code against a module, the code was working. if (amt := self._data[index.row()][index.column()]) \ and float(amt) < 0.0: return QColor('red') I got the above error and had to change it to the below to clear the error. amt = self._data[index.row()][index.column()] if amt and float(amt) < 0.0: return QColor('red') I had thought the walrus was implemented to foster this style of code. Thanks, Ed

Attachments:

attachment.htm (text/html — 1005 bytes)

Reply

Sign in to reply online Use email software

Show replies by thread

Ian Stapleton Cordasco

31 May 31 May

2:22 p.m.

What was the exact error you encountered? Sent from my phone with my typo-happy thumbs. Please excuse my brevity On Mon, May 31, 2021, 09:19 Ed Lipson wrote:

I was running pylint (2.6.0) in VS Code against a module, the code was working.

if (amt := self._data[index.row()][index.column()]) \ and float(amt) < 0.0: return QColor('red')

I got the above error and had to change it to the below to clear the error.

amt = self._data[index.row()][index.column()] if amt and float(amt) < 0.0: return QColor('red')

I had thought the walrus was implemented to foster this style of code.

Thanks, Ed

_______________________________________________ code-quality mailing list -- code-quality@python.org To unsubscribe send an email to code-quality-leave@python.org https://mail.python.org/mailman3/lists/code-quality.python.org/ Member address: graffatcolmingov@gmail.com

Reply

Sign in to reply online Use email software

Mariatta

2:26 p.m.

This was an issue with pylint and was fixed in pylint v 2.8.0. Changelog: http://pylint.pycqa.org/en/latest/whatsnew/changelog.html#what-s-new-in-pyli... On Mon., May 31, 2021, 7:19 a.m. Ed Lipson, wrote:

I was running pylint (2.6.0) in VS Code against a module, the code was working.

if (amt := self._data[index.row()][index.column()]) \ and float(amt) < 0.0: return QColor('red')

I got the above error and had to change it to the below to clear the error.

amt = self._data[index.row()][index.column()] if amt and float(amt) < 0.0: return QColor('red')

I had thought the walrus was implemented to foster this style of code.

Thanks, Ed

_______________________________________________ code-quality mailing list -- code-quality@python.org To unsubscribe send an email to code-quality-leave@python.org https://mail.python.org/mailman3/lists/code-quality.python.org/ Member address: mariatta@python.org

Reply

Sign in to reply online Use email software

Pierre Sassoulas

2:31 p.m.

Hello, You should upgrade pylint to the latest version, in order to get supports for the walrus operator (2.8 or superior has it, maybe even 2.7.4). The match pattern will only be supported in the next major version too (2.9.0). Best regards, Le lun. 31 mai 2021 à 16:22, Ian Stapleton Cordasco < graffatcolmingov@gmail.com> a écrit :

What was the exact error you encountered?

Sent from my phone with my typo-happy thumbs. Please excuse my brevity

On Mon, May 31, 2021, 09:19 Ed Lipson wrote:

...
I was running pylint (2.6.0) in VS Code against a module, the code was working.

if (amt := self._data[index.row()][index.column()]) \ and float(amt) < 0.0: return QColor('red')

I got the above error and had to change it to the below to clear the error.

amt = self._data[index.row()][index.column()] if amt and float(amt) < 0.0: return QColor('red')

I had thought the walrus was implemented to foster this style of code.

Thanks, Ed

_______________________________________________ code-quality mailing list -- code-quality@python.org To unsubscribe send an email to code-quality-leave@python.org https://mail.python.org/mailman3/lists/code-quality.python.org/ Member address: graffatcolmingov@gmail.com

_______________________________________________ code-quality mailing list -- code-quality@python.org To unsubscribe send an email to code-quality-leave@python.org https://mail.python.org/mailman3/lists/code-quality.python.org/ Member address: pierre.sassoulas@gmail.com

Reply

Sign in to reply online Use email software

1060

Age (days ago)

1061

Last active (days ago)

Download

3 comments

4 participants

tags

participants (4)

Ed Lipson
Ian Stapleton Cordasco
Mariatta
Pierre Sassoulas