[core-workflow] Re: Workflow for the PR?

On Tue, 15 May 2018 at 13:03 Berker Peksağ wrote:

On Tue, May 15, 2018 at 6:12 PM, Stephane Wirtel wrote:

...

For me, normally, the label should be on "awaiting changes" and after a new commit/message from the author, the label should be "awaiting review"

The reviewer wasn't a core developer so we need to get a approval/review from a core developer before moving to the next step (for example, a core developer may disagree with the non-core reviewer's comments or suggest a different approach)

And the reason we want a core review is we have no idea if the review by a non-core reviewer is reasonable. E.g. someone might be extremely pedantic about PEP 8 when a core dev wouldn't be in all situations, so holding up a PR for that wouldn't be fair for the PR submitter.