On Jul 23, 2018, at 4:34 AM, Victor Stinner <vstinner@redhat.com> wrote:
2018-07-23 3:28 GMT+02:00 Berker Peksağ <berker.peksag@gmail.com>:
On Fri, Jul 20, 2018 at 9:49 PM, Mariatta Wijaya <mariatta.wijaya@gmail.com> wrote:
Several of its features I'd like to try out for now: - automatically add size labels on pull requests. It can analyze the content of the pull request, and apply the size labels (xs, s, m, etc)
It would be better if we use less labels, to be honest. Even now, the amount of labels and different colors make the pull request list harder to look at: https://github.com/python/cpython/pulls
And I don't find these labels useful especially if there is no way to ignore auto-generated files such as Python/importlib.h.
I concur with Berker. More and more PR look like a blinking christmas tree :-) IMHO labels doesn't add much value for the reviews.
A couple of years ago, I completely agreed that the labels were distracting when we were using them on Jupyter. Over time, I found that they were very helpful for triaging issues and viewing status/next actions when you have a large number of PRs. One thing that I found helped quite a bit with the Christmas tree effect was to standardize the color scheme to either all black lettering on muted color or all white lettering on bright color.
Victor _______________________________________________ core-workflow mailing list -- core-workflow@python.org To unsubscribe send an email to core-workflow-leave@python.org https://mail.python.org/mm3/mailman3/lists/core-workflow.python.org/ This list is governed by the PSF Code of Conduct: https://www.python.org/psf/codeofconduct