Thinking to the future, eh? 😉 While I don't have a fundamental objection, what does this get you that an issue doesn't? Since the code will be sitting in your fork for that length it wont be lost. Is it to make it easier to keep it synced and tested for the next year? On Sat., Sep. 15, 2018, 02:16 Ethan Furman, <ethan@stoneleaf.us> wrote:
On Sat, 15 Sep 2018 09:08:12 -0700 Brett Cannon <brett@python.org> wrote:
PRs can be nice for CI or to allow other people to review work in progress code. But I don't exactly see the point of a dedicated tag either, you can just add "[DO NOT MERGE]" at the beginning of the PR title and hopefully everyone will understand... except the bot? ;-) Regards Antoine.
On 09/15/2018 09:08 AM, Brett Cannon wrote:
Thinking to the future, eh? 😉
:-)
While I don't have a fundamental objection, what does this get you that an issue doesn't? Since the code will be sitting in your fork for that length it wont be lost. Is it to make it easier to keep it synced and tested for the next year?
Mostly to make it easier for me not to forget to do it. ;) I suppose a separate issue with that text in the title would also work. -- ~Ethan~
Thinking to the future, eh? 😉 While I don't have a fundamental objection, what does this get you that an issue doesn't? Since the code will be sitting in your fork for that length it wont be lost. Is it to make it easier to keep it synced and tested for the next year? On Sat., Sep. 15, 2018, 02:16 Ethan Furman, <ethan@stoneleaf.us> wrote:
On Sat, 15 Sep 2018 09:08:12 -0700 Brett Cannon <brett@python.org> wrote:
PRs can be nice for CI or to allow other people to review work in progress code. But I don't exactly see the point of a dedicated tag either, you can just add "[DO NOT MERGE]" at the beginning of the PR title and hopefully everyone will understand... except the bot? ;-) Regards Antoine.
On 09/15/2018 09:08 AM, Brett Cannon wrote:
Thinking to the future, eh? 😉
:-)
While I don't have a fundamental objection, what does this get you that an issue doesn't? Since the code will be sitting in your fork for that length it wont be lost. Is it to make it easier to keep it synced and tested for the next year?
Mostly to make it easier for me not to forget to do it. ;) I suppose a separate issue with that text in the title would also work. -- ~Ethan~
participants (5)
-
Antoine Pitrou -
Brett Cannon -
Ethan Furman -
francismb -
Victor Stinner