Thinking to the future, eh? 😉
While I don't have a fundamental objection, what does this get you that an issue doesn't? Since the code will be sitting in your fork for that length it wont be lost. Is it to make it easier to keep it synced and tested for the next year?
On Sat., Sep. 15, 2018, 02:16 Ethan Furman, ethan@stoneleaf.us wrote:
Can we get the above tag added?
-- ~Ethan~ _______________________________________________ core-workflow mailing list -- core-workflow@python.org To unsubscribe send an email to core-workflow-leave@python.org https://mail.python.org/mm3/mailman3/lists/core-workflow.python.org/ This list is governed by the PSF Code of Conduct: https://www.python.org/psf/codeofconduct
On Sat, 15 Sep 2018 09:08:12 -0700 Brett Cannon brett@python.org wrote:
Thinking to the future, eh? 😉
While I don't have a fundamental objection, what does this get you that an issue doesn't? Since the code will be sitting in your fork for that length it wont be lost. Is it to make it easier to keep it synced and tested for the next year?
PRs can be nice for CI or to allow other people to review work in progress code.
But I don't exactly see the point of a dedicated tag either, you can just add "[DO NOT MERGE]" at the beginning of the PR title and hopefully everyone will understand... except the bot? ;-)
Regards
Antoine.
On 09/15/2018 09:08 AM, Brett Cannon wrote:
Thinking to the future, eh? 😉
:-)
While I don't have a fundamental objection, what does this get you that an issue doesn't? Since the code will be sitting in your fork for that length it wont be lost. Is it to make it easier to keep it synced and tested for the next year?
Mostly to make it easier for me not to forget to do it. ;)
I suppose a separate issue with that text in the title would also work.
-- ~Ethan~
IMHO DO-NOT-MERGE is good enough, no? Why do you want a different label for the same thing? Just add a comment to explain that you target 3.9 ;-)
Victor, now curious to see that PR ;-)
Le samedi 15 septembre 2018, Ethan Furman ethan@stoneleaf.us a écrit :
Can we get the above tag added?
-- ~Ethan~ _______________________________________________ core-workflow mailing list -- core-workflow@python.org To unsubscribe send an email to core-workflow-leave@python.org https://mail.python.org/mm3/mailman3/lists/core-workflow.python.org/ This list is governed by the PSF Code of Conduct:
participants (5)
-
Antoine Pitrou -
Brett Cannon -
Ethan Furman -
francismb -
Victor Stinner