Travis is now required to be passing, reviews are not
25 Feb
2017
25 Feb
'17
12:31 a.m.
I didn't turn on Codecov requirements for the patch because we seem to still have variance in them where some module that are inconsistently being tested (there is a test for the whole project but I left that off as well). I think we should definitely work towards fixing the coverage variance as I would like to require no drop in code coverage at some point, but as of right now it's wonky enough to be too much of a showstopper to flip on. I have opened https://github.com/python/core-workflow/issues/38 to track this and any modules whose coverage is inconsistent so we can eventually fix this and require coverage doesn't decrease.
2837
Age (days ago)
2837
Last active (days ago)
0 comments
1 participants
participants (1)
-
Brett Cannon