Turning off bedevere-bot messages for core dev PRs?
When reviewing other core dev's PRs, the extra state change messages from bedevere-bot don't feel especially helpful.
How would folks feel about the idea of tweaking the bot to check if the PR submitter was a core dev, and skip the process explanation messages in that case?
Cheers, Nick.
So basically you want it to be permanently set to "awaiting merge" when a core dev is the PR creator regardless of where the reviews come from? The other option is introducing an 'awaiting nothing' label that automatically applies to PRs authored by core devs and that basically turns off touching the "awaiting" label.
On Mon, 20 Nov 2017 at 18:16 Nick Coghlan ncoghlan@gmail.com wrote:
When reviewing other core dev's PRs, the extra state change messages from bedevere-bot don't feel especially helpful.
How would folks feel about the idea of tweaking the bot to check if the PR submitter was a core dev, and skip the process explanation messages in that case?
Cheers, Nick.
-- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia _______________________________________________ core-workflow mailing list -- core-workflow@python.org To unsubscribe send an email to core-workflow-leave@python.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s This list is governed by the PSF Code of Conduct: https://www.python.org/psf/codeofconduct
How would folks feel about the idea of tweaking the bot to check if the PR submitter was a core dev, and skip the process explanation messages in that case?
From what I understand, what you're asking is that the state change label still gets applied, (for example the 'awaiting changes' label) but you don't want bedevere-bot to leave the comment "A Python core developer has requested some changes ..." if the PR author is a core developer?
I'm +0, it doesn't bother me much. I think the other message: "please review the changes made to this pull request" should remain.
Mariatta Wijaya
On 22 November 2017 at 13:24, Mariatta Wijaya mariatta.wijaya@gmail.com wrote:
How would folks feel about the idea of tweaking the bot to check if
the PR submitter was a core dev, and skip the process explanation messages in that case?
From what I understand, what you're asking is that the state change label still gets applied, (for example the 'awaiting changes' label) but you don't want bedevere-bot to leave the comment "A Python core developer has requested some changes ..." if the PR author is a core developer?
Aye, that's the specific message that makes me roll my eyes and think "Yes, Bedevere, thank you, I already know how that bit of the process works".
I think the other message: "please review the changes made to this pull
request" should remain.
Good point, that's a useful prompt regardless of who wrote the original PR.
Cheers, Nick.
Gotcha :)
Well the useful part of that message is it contains the phrase: "I have made the requested changes; please review again". I think it's convenient to be able to copy paste it to trigger the next state change.
Maybe for core devs, we can shorten the message to at least include the trigger phrase.
Mariatta Wijaya
On Tue, Nov 21, 2017 at 11:52 PM, Nick Coghlan ncoghlan@gmail.com wrote:
On 22 November 2017 at 13:24, Mariatta Wijaya mariatta.wijaya@gmail.com wrote:
How would folks feel about the idea of tweaking the bot to check if
the PR submitter was a core dev, and skip the process explanation messages in that case?
From what I understand, what you're asking is that the state change label still gets applied, (for example the 'awaiting changes' label) but you don't want bedevere-bot to leave the comment "A Python core developer has requested some changes ..." if the PR author is a core developer?
Aye, that's the specific message that makes me roll my eyes and think "Yes, Bedevere, thank you, I already know how that bit of the process works".
I think the other message: "please review the changes made to this pull
request" should remain.
Good point, that's a useful prompt regardless of who wrote the original PR.
Cheers, Nick.
-- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia
I'm totally fine with the idea of having a core-specific, short message of "There's a review; the trigger phrase is '...'".
On Wed, 22 Nov 2017 at 09:33 Mariatta Wijaya mariatta.wijaya@gmail.com wrote:
Gotcha :)
Well the useful part of that message is it contains the phrase: "I have made the requested changes; please review again". I think it's convenient to be able to copy paste it to trigger the next state change.
Maybe for core devs, we can shorten the message to at least include the trigger phrase.
Mariatta Wijaya
On Tue, Nov 21, 2017 at 11:52 PM, Nick Coghlan ncoghlan@gmail.com wrote:
On 22 November 2017 at 13:24, Mariatta Wijaya mariatta.wijaya@gmail.com wrote:
How would folks feel about the idea of tweaking the bot to check if
the PR submitter was a core dev, and skip the process explanation messages in that case?
From what I understand, what you're asking is that the state change label still gets applied, (for example the 'awaiting changes' label) but you don't want bedevere-bot to leave the comment "A Python core developer has requested some changes ..." if the PR author is a core developer?
Aye, that's the specific message that makes me roll my eyes and think "Yes, Bedevere, thank you, I already know how that bit of the process works".
I think the other message: "please review the changes made to this pull
request" should remain.
Good point, that's a useful prompt regardless of who wrote the original PR.
Cheers, Nick.
-- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia
In https://github.com/python/bedevere/pull/75, the message is shorten to:
When you're done making the requested changes, leave the comment: `I have made the requested changes; please review again`
participants (3)
-
Brett Cannon -
Mariatta Wijaya -
Nick Coghlan