confusing result from `make patchcheck`
Running `make patchcheck` resulted in the following: Getting the list of files that have been added/changed ... fatal: ambiguous argument 'origin/3.7': unknown revision or path not in the working tree. How does one fix that? The commands leading up to this: git checkout -b bpo-33217-3.7 upstream/3.7 <edit Lib/enum.py and Lib/test/test_enum.py> make distclean cp Modules/Setup.dist Modules/Setup ./configure --with-pydebug && make -j2 ./python -m test.regrtest test_enum.py ./python -m test.regrtest make patcheck Any help appreciated! :) -- ~Ethan~
On Thu, Apr 05, 2018 at 07:31:02AM -0700, Ethan Furman <ethan@stoneleaf.us> wrote:
git fetch origin 3.7:3.7
-- ~Ethan~
Oleg. -- Oleg Broytman http://phdru.name/ phd@phdru.name Programmers don't die, they just GOSUB without RETURN.
On 04/05/2018 08:07 AM, Oleg Broytman wrote:
On Thu, Apr 05, 2018 at 07:31:02AM -0700, Ethan Furman wrote:
Resulted in: ethan@code:~/source/git-python/cpython$ git fetch 3.7:3.7 ssh: connect to host 3.7 port 22: Connection timed out fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. -- ~Ethan~
On Thu, Apr 05, 2018 at 09:11:14AM -0700, Ethan Furman <ethan@stoneleaf.us> wrote:
git fetch origin 3.7:3.7 ^^^^^^
Oleg. -- Oleg Broytman http://phdru.name/ phd@phdru.name Programmers don't die, they just GOSUB without RETURN.
On 04/05/2018 09:21 AM, Oleg Broytman wrote:
Ah, oops. Okay, tried again, still seeing problem. ethan@code:~/source/git-python/cpython$ git fetch origin 3.7:3.7 fatal: Couldn't find remote ref 3.7 ethan@code:~/source/git-python/cpython$ git fetch upstream 3.7:3.7 From github.com:python/cpython * [new branch] 3.7 -> 3.7 ethan@code:~/source/git-python/cpython$ git branch 3.7 bpo-29237 * bpo-33217-3.7 enum_ignore master ethan@code:~/source/git-python/cpython$ make patchcheck running build running build_ext Python build finished successfully! The necessary bits to build these optional modules were not found: _dbm _gdbm _ssl _uuid To find the necessary bits, look in setup.py in detect_modules() for the module's name. The following modules found by detect_modules() in setup.py, have been built by the Makefile instead, as configured by the Setup files: _abc atexit pwd time Could not build the ssl module! Python requires an OpenSSL 1.0.2 or 1.1 compatible libssl with X509_VERIFY_PARAM_set1_host(). LibreSSL 2.6.4 and earlier do not provide the necessary APIs, https://github.com/libressl-portable/portable/issues/381 running build_scripts copying and adjusting /home/ethan/source/git-python/cpython/Tools/scripts/pydoc3 -> build/scripts-3.7 copying and adjusting /home/ethan/source/git-python/cpython/Tools/scripts/idle3 -> build/scripts-3.7 copying and adjusting /home/ethan/source/git-python/cpython/Tools/scripts/2to3 -> build/scripts-3.7 copying and adjusting /home/ethan/source/git-python/cpython/Tools/scripts/pyvenv -> build/scripts-3.7 changing mode of build/scripts-3.7/pydoc3 from 664 to 775 changing mode of build/scripts-3.7/idle3 from 664 to 775 changing mode of build/scripts-3.7/2to3 from 664 to 775 changing mode of build/scripts-3.7/pyvenv from 664 to 775 renaming build/scripts-3.7/pydoc3 to build/scripts-3.7/pydoc3.7 renaming build/scripts-3.7/idle3 to build/scripts-3.7/idle3.7 renaming build/scripts-3.7/2to3 to build/scripts-3.7/2to3-3.7 renaming build/scripts-3.7/pyvenv to build/scripts-3.7/pyvenv-3.7 ./python ./Tools/scripts/patchcheck.py Getting base branch for PR ... origin/3.7 Getting the list of files that have been added/changed ... fatal: ambiguous argument 'origin/3.7': unknown revision or path not in the working tree. Use '--' to separate paths from revisions, like this: 'git <command> [<revision>...] -- [<file>...]' 0 files Fixing Python file whitespace ... 0 files Fixing C file whitespace ... 0 files Fixing docs whitespace ... 0 files Docs modified ... NO Misc/ACKS updated ... NO Misc/NEWS.d updated with `blurb` ... NO configure regenerated ... not needed pyconfig.h.in regenerated ... not needed -- ~Ethan~
On Thu, Apr 05, 2018 at 10:37:29AM -0700, Ethan Furman <ethan@stoneleaf.us> wrote:
The script works with both `upstream` if it can find such remote or `origin` otherwise: https://github.com/python/cpython/blob/master/Tools/scripts/patchcheck.py#L6... After you fetched `upstream/3.7` it started to work.
-- ~Ethan~
Oleg. -- Oleg Broytman http://phdru.name/ phd@phdru.name Programmers don't die, they just GOSUB without RETURN.
On Thu, Apr 05, 2018 at 07:31:02AM -0700, Ethan Furman <ethan@stoneleaf.us> wrote:
git fetch origin 3.7:3.7
-- ~Ethan~
Oleg. -- Oleg Broytman http://phdru.name/ phd@phdru.name Programmers don't die, they just GOSUB without RETURN.
On 04/05/2018 08:07 AM, Oleg Broytman wrote:
On Thu, Apr 05, 2018 at 07:31:02AM -0700, Ethan Furman wrote:
Resulted in: ethan@code:~/source/git-python/cpython$ git fetch 3.7:3.7 ssh: connect to host 3.7 port 22: Connection timed out fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. -- ~Ethan~
On Thu, Apr 05, 2018 at 09:11:14AM -0700, Ethan Furman <ethan@stoneleaf.us> wrote:
git fetch origin 3.7:3.7 ^^^^^^
Oleg. -- Oleg Broytman http://phdru.name/ phd@phdru.name Programmers don't die, they just GOSUB without RETURN.
On 04/05/2018 09:21 AM, Oleg Broytman wrote:
Ah, oops. Okay, tried again, still seeing problem. ethan@code:~/source/git-python/cpython$ git fetch origin 3.7:3.7 fatal: Couldn't find remote ref 3.7 ethan@code:~/source/git-python/cpython$ git fetch upstream 3.7:3.7 From github.com:python/cpython * [new branch] 3.7 -> 3.7 ethan@code:~/source/git-python/cpython$ git branch 3.7 bpo-29237 * bpo-33217-3.7 enum_ignore master ethan@code:~/source/git-python/cpython$ make patchcheck running build running build_ext Python build finished successfully! The necessary bits to build these optional modules were not found: _dbm _gdbm _ssl _uuid To find the necessary bits, look in setup.py in detect_modules() for the module's name. The following modules found by detect_modules() in setup.py, have been built by the Makefile instead, as configured by the Setup files: _abc atexit pwd time Could not build the ssl module! Python requires an OpenSSL 1.0.2 or 1.1 compatible libssl with X509_VERIFY_PARAM_set1_host(). LibreSSL 2.6.4 and earlier do not provide the necessary APIs, https://github.com/libressl-portable/portable/issues/381 running build_scripts copying and adjusting /home/ethan/source/git-python/cpython/Tools/scripts/pydoc3 -> build/scripts-3.7 copying and adjusting /home/ethan/source/git-python/cpython/Tools/scripts/idle3 -> build/scripts-3.7 copying and adjusting /home/ethan/source/git-python/cpython/Tools/scripts/2to3 -> build/scripts-3.7 copying and adjusting /home/ethan/source/git-python/cpython/Tools/scripts/pyvenv -> build/scripts-3.7 changing mode of build/scripts-3.7/pydoc3 from 664 to 775 changing mode of build/scripts-3.7/idle3 from 664 to 775 changing mode of build/scripts-3.7/2to3 from 664 to 775 changing mode of build/scripts-3.7/pyvenv from 664 to 775 renaming build/scripts-3.7/pydoc3 to build/scripts-3.7/pydoc3.7 renaming build/scripts-3.7/idle3 to build/scripts-3.7/idle3.7 renaming build/scripts-3.7/2to3 to build/scripts-3.7/2to3-3.7 renaming build/scripts-3.7/pyvenv to build/scripts-3.7/pyvenv-3.7 ./python ./Tools/scripts/patchcheck.py Getting base branch for PR ... origin/3.7 Getting the list of files that have been added/changed ... fatal: ambiguous argument 'origin/3.7': unknown revision or path not in the working tree. Use '--' to separate paths from revisions, like this: 'git <command> [<revision>...] -- [<file>...]' 0 files Fixing Python file whitespace ... 0 files Fixing C file whitespace ... 0 files Fixing docs whitespace ... 0 files Docs modified ... NO Misc/ACKS updated ... NO Misc/NEWS.d updated with `blurb` ... NO configure regenerated ... not needed pyconfig.h.in regenerated ... not needed -- ~Ethan~
On Thu, Apr 05, 2018 at 10:37:29AM -0700, Ethan Furman <ethan@stoneleaf.us> wrote:
The script works with both `upstream` if it can find such remote or `origin` otherwise: https://github.com/python/cpython/blob/master/Tools/scripts/patchcheck.py#L6... After you fetched `upstream/3.7` it started to work.
-- ~Ethan~
Oleg. -- Oleg Broytman http://phdru.name/ phd@phdru.name Programmers don't die, they just GOSUB without RETURN.
participants (3)
-
Chris Angelico -
Ethan Furman -
Oleg Broytman