Requirements to make AppVeyor a required status check
https://github.com/python/core-workflow/issues/41 is tracking the idea of requiring AppVeyor to pass for a PR to be mergeable so as to prevent people breaking Windows. Since two commits fixing tests for AppVeyor just landed I want to see if we can go a week without AppVeyor failing because of AppVeyor itself. If that threshold is met, I plan to turn on the requirement. I'm stating this here mostly so people know to update the issue if a transient failure is spotted so that it can be fixed and the one-week clock can be reset.
On Fri, 02 Jun 2017 19:10:52 +0000 Brett Cannon <brett@python.org> wrote:
https://github.com/python/core-workflow/issues/41 is tracking the idea of requiring AppVeyor to pass for a PR to be mergeable so as to prevent people breaking Windows. Since two commits fixing tests for AppVeyor just landed I want to see if we can go a week without AppVeyor failing because of AppVeyor itself. If that threshold is met, I plan to turn on the requirement.
Is our AppVeyor hook still active? I can't see any build appearing here: https://github.com/python/cpython/pull/1922 Regards Antoine.
On Sat, 3 Jun 2017 at 03:17 Antoine Pitrou <solipsis@pitrou.net> wrote:
https://github.com/python/core-workflow/issues/41 is tracking the idea of requiring AppVeyor to pass for a PR to be mergeable so as to prevent
On Fri, 02 Jun 2017 19:10:52 +0000 Brett Cannon <brett@python.org> wrote: people
breaking Windows. Since two commits fixing tests for AppVeyor just landed I want to see if we can go a week without AppVeyor failing because of AppVeyor itself. If that threshold is met, I plan to turn on the requirement.
Is our AppVeyor hook still active? I can't see any build appearing here: https://github.com/python/cpython/pull/1922
Yep as it built your commit: https://ci.appveyor.com/project/python/cpython/branch/master. So that would suggest that AppVeyor either had a hiccup and missed your PR or they got a bug in their hook.
participants (2)
-
Antoine Pitrou -
Brett Cannon