pyregr testsuite regression
Vitja Makarov, 23.08.2011 06:26:
Hudson shows regression for last 4 pyregr builds.
Yes, I enabled the "always_allow_keywords" option for better Python compatibility, which disables the signature optimisation into METH_O & friends for def functions. That helped in a couple of cases but broke others. The regression appears to be mostly because generator expressions do not work with this option: http://trac.cython.org/cython_trac/ticket/720 CyFunction may or may not drop the need for that option eventually, but for now, it would be good to fix it. I also wouldn't object to switching it off again, in case it's not an easy fix (I tried but didn't find the right place to fix it). Stefan
2011/8/23 Stefan Behnel <stefan_ml@behnel.de>:
Vitja Makarov, 23.08.2011 06:26:
Hudson shows regression for last 4 pyregr builds.
Yes, I enabled the "always_allow_keywords" option for better Python compatibility, which disables the signature optimisation into METH_O & friends for def functions. That helped in a couple of cases but broke others. The regression appears to be mostly because generator expressions do not work with this option:
http://trac.cython.org/cython_trac/ticket/720
CyFunction may or may not drop the need for that option eventually, but for now, it would be good to fix it.
I also wouldn't object to switching it off again, in case it's not an easy fix (I tried but didn't find the right place to fix it).
Ok. I'll take a look later. -- vitja.
On Mon, Aug 22, 2011 at 9:41 PM, Stefan Behnel <stefan_ml@behnel.de> wrote:
Vitja Makarov, 23.08.2011 06:26:
Hudson shows regression for last 4 pyregr builds.
Yes, I enabled the "always_allow_keywords" option for better Python compatibility, which disables the signature optimisation into METH_O & friends for def functions. That helped in a couple of cases but broke others. The regression appears to be mostly because generator expressions do not work with this option:
http://trac.cython.org/cython_trac/ticket/720
CyFunction may or may not drop the need for that option eventually, but for now, it would be good to fix it.
I also wouldn't object to switching it off again, in case it's not an easy fix (I tried but didn't find the right place to fix it).
IIRC, it is a significant performance penalty to turn that off (which is why it's disabled by default). We should at least allow one to disable it. - Robert
2011/8/23 Robert Bradshaw <robertwb@math.washington.edu>:
On Mon, Aug 22, 2011 at 9:41 PM, Stefan Behnel <stefan_ml@behnel.de> wrote:
Vitja Makarov, 23.08.2011 06:26:
Hudson shows regression for last 4 pyregr builds.
Yes, I enabled the "always_allow_keywords" option for better Python compatibility, which disables the signature optimisation into METH_O & friends for def functions. That helped in a couple of cases but broke others. The regression appears to be mostly because generator expressions do not work with this option:
http://trac.cython.org/cython_trac/ticket/720
CyFunction may or may not drop the need for that option eventually, but for now, it would be good to fix it.
I also wouldn't object to switching it off again, in case it's not an easy fix (I tried but didn't find the right place to fix it).
IIRC, it is a significant performance penalty to turn that off (which is why it's disabled by default). We should at least allow one to disable it.
That's switched on only for pyregr tests -- vitja.
2011/8/23 Vitja Makarov <vitja.makarov@gmail.com>:
2011/8/23 Robert Bradshaw <robertwb@math.washington.edu>:
On Mon, Aug 22, 2011 at 9:41 PM, Stefan Behnel <stefan_ml@behnel.de> wrote:
Vitja Makarov, 23.08.2011 06:26:
Hudson shows regression for last 4 pyregr builds.
Yes, I enabled the "always_allow_keywords" option for better Python compatibility, which disables the signature optimisation into METH_O & friends for def functions. That helped in a couple of cases but broke others. The regression appears to be mostly because generator expressions do not work with this option:
http://trac.cython.org/cython_trac/ticket/720
CyFunction may or may not drop the need for that option eventually, but for now, it would be good to fix it.
I also wouldn't object to switching it off again, in case it's not an easy fix (I tried but didn't find the right place to fix it).
IIRC, it is a significant performance penalty to turn that off (which is why it's disabled by default). We should at least allow one to disable it.
That's switched on only for pyregr tests
I've fixed it here https://github.com/cython/cython/commit/7c01e8488e12f5e7581a356df5882d532945... -- vitja.
Vitja Makarov, 23.08.2011 07:29:
2011/8/23 Vitja Makarov:
2011/8/23 Robert Bradshaw:
On Mon, Aug 22, 2011 at 9:41 PM, Stefan Behnel wrote:
Vitja Makarov, 23.08.2011 06:26:
Hudson shows regression for last 4 pyregr builds.
Yes, I enabled the "always_allow_keywords" option for better Python compatibility, which disables the signature optimisation into METH_O& friends for def functions. That helped in a couple of cases but broke others. The regression appears to be mostly because generator expressions do not work with this option:
http://trac.cython.org/cython_trac/ticket/720
CyFunction may or may not drop the need for that option eventually, but for now, it would be good to fix it.
I also wouldn't object to switching it off again, in case it's not an easy fix (I tried but didn't find the right place to fix it).
IIRC, it is a significant performance penalty to turn that off (which is why it's disabled by default). We should at least allow one to disable it.
That's switched on only for pyregr tests
Right, but it's still a useful option for Python compatibility in general.
I've fixed it here https://github.com/cython/cython/commit/7c01e8488e12f5e7581a356df5882d532945...
Ah, given the right pair of eyeballs ... Thanks! Stefan
participants (3)
-
Robert Bradshaw -
Stefan Behnel -
Vitja Makarov