On 05/27/2011 02:41 PM, Vitja Makarov wrote:

2011/5/27 Stefan Behnel<stefan_ml@behnel.de>:

...

Hi,

could we please make it a requirement to run the complete test suite after a branch merge? Or at least taking a close look at Jenkins after pushing a merge? And then fixing the bugs it finds?

Stefan

There are failing tests in _control_flow branch. I guess it's better to fix them after merge.

Wouldn't it be better to rebase _control_flow on master, then fix tests, then merge it into master? (Replace "rebase" with "merge in master" if you wish, I'm going by the _ prefix here.) Dag Sverre

On Fri, May 27, 2011 at 6:16 AM, Vitja Makarov <vitja.makarov@gmail.com> wrote:

2011/5/27 Dag Sverre Seljebotn <d.s.seljebotn@astro.uio.no>:

...

On 05/27/2011 02:41 PM, Vitja Makarov wrote:

...

2011/5/27 Stefan Behnel<stefan_ml@behnel.de>:

...

Hi,

could we please make it a requirement to run the complete test suite after a branch merge? Or at least taking a close look at Jenkins after pushing a merge? And then fixing the bugs it finds?

Stefan

There are failing tests in _control_flow branch. I guess it's better to fix them after merge.

Wouldn't it be better to rebase _control_flow on master, then fix tests, then merge it into master?

+1

...

(Replace "rebase" with "merge in master" if you wish, I'm going by the _ prefix here.)

Sure. But I think that I need some help to make decision which tests should be fixed and which removed.

Do you have any specific tests that are unclear? In any case, I think this email was primarily aimed at me, as there was a conflict with the with-gil branch and the pure cdef function branch that I didn't catch before I merged. (I had planned to take a look at the results later, but my day got too crazy...) +1 to the policy of running the entire testsuite on at least one Python before pushing a merge. - Robert